fix(memory): Qdrant memory async/runtime — recall re-entry, async drop, honest gated tests (#348/#349/#358)

[gnanirahulnutakki]

Fixes #348, #349, #358 — three defects in the durable/hybrid Qdrant memory backend that share one root: it owns a nested multi-thread Tokio runtime and bridges the synchronous MemoryRuntime trait onto it via block_on.

Root causes (verified in-tree)

#348 (High) — hybrid recall panics the turn (nested block_on).
HybridMemoryRetriever::search_scoped (sync trait) did qdrant.block_on(search_for_subject) (level‑1). Inside that awaited future, search_filtered called the synchronous dead_chains / search_vectors / fetch_record, each of which re‑bridged via block_on (level‑2). At level‑2, Handle::try_current() returns the same owned multi‑thread rt, so the flavor‑only guard (runtime_flavor() == MultiThread) took block_in_place(|| rt.block_on(..)) and re‑entered the same runtime → Cannot start a runtime from within a runtime. The write path (record → sync qdrant.record) had the identical latent nesting.

#349 (High) — durable backend panics when dropped from async.
rt: tokio::runtime::Runtime was owned inline with no Drop. Dropping the Arc from an async context (server shutdown, or end of a turn) panics: Cannot drop a runtime in a context where blocking is not allowed.

#358 (Medium) — gated tests report passed without running.
Both e2e scenarios (and the crate's own integration.rs / hybrid_integration.rs) used a return None env‑gate with no #[ignore], so the default suite printed green while the durable/hybrid paths never ran — which is exactly why #349 was invisible in CI.

Fix

• runtime.rs — single‑bridge async cores. Each inherent op now has an async core (record_async, search_vectors_async, search_text_async, fetch_record_async, dead_chains (now async), scroll_records_async, get_record_async) holding the real logic; every sync method is a thin block_on(..async..) wrapper over one core. A single logical call therefore bridges exactly once and never nests. hybrid.rs awaits the async cores directly (search_filtered, record, fetch_live).
• Identity guard (backstop). block_on_runtime now compares runtime identity (Handle::id()), not just flavor: if the ambient runtime is our own rt, it drives on a dedicated scoped thread instead of re‑entering. Defense‑in‑depth even though the refactor removes the nesting.
• Non‑blocking Drop ([High] Qdrant durable-memory backend panics when dropped from an async context #349). rt: Option<Runtime> + impl Drop → shutdown_background(), which signals the workers and returns immediately, so the drop is safe from any context.
• Honest gated tests ([Medium] Gated Qdrant integration tests report 'passed' without running (masks a real panic) #358). Every gated Qdrant test is #[ignore]d — it reports as ignored, never a masked passed — and actually executes under --ignored against a live Qdrant. A new ci.yml job (qdrant-integration) boots qdrant/qdrant:v1.18.0 as a service and runs the curated --ignored set.

Public API is additive only (new *_async methods; no sync signature changed) — ardur-server and ardur-admin compile unchanged.

Verification

Default suites (no Qdrant): ardur-memory-qdrant lib+config green; integration/hybrid_integration now report ignored (were silently passed); cargo test -p ardur-e2e-tests green with both Qdrant scenarios reported ignored. clippy -D warnings + fmt clean.

Against a live Qdrant (qdrant/qdrant:v1.18.0, gRPC 6334):

Test	Proves	Result
scenario_qdrant_memory_persistence	#349 async‑context drop	✅ pass
scenario_hybrid_memory_full_pipeline	#348 fused‑runtime recall re‑entry	✅ pass
integration::{insert_then_query, invalidate_preserves_history_and_past, survives_simulated_restart}	durable read/write/restart	✅ pass
hybrid_integration::{record_writes_to_both, search_respects_top_k, recall_excludes_invalidated_memory}	hybrid dense+sparse recall	✅ pass
runtime::tests::block_on_runtime_survives_reentry_on_its_own_runtime (unit)	reproduces the #348 re‑entry	✅ pass

Out of scope / follow‑up

snapshot_into_receipt_records_event fails against live Qdrant: qdrant-client's default 5s request deadline is too short for gRPC snapshot creation (REST snapshot is ~1s). This is a separate, pre‑existing snapshot‑timeout bug unrelated to #348/#349 — excluded from the CI sweep via --skip and left for a dedicated follow‑up. The two *semantic* hybrid tests additionally need the BGE model download and are --skipped in CI (documented to run by name locally).

Do not merge — leaving for peer review.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: af83763b-8932-4b2a-8fcc-67c56c65538f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/qdrant-memory-async-runtime

---

_{Comment @coderabbitai help to get the list of available commands.}