feat(channels,pwa): add email channel adapter + PWA Web Push substrate - #336
Open
gnanirahulnutakki wants to merge 4 commits into
Open
feat(channels,pwa): add email channel adapter + PWA Web Push substrate#336gnanirahulnutakki wants to merge 4 commits into
gnanirahulnutakki wants to merge 4 commits into
Conversation
Adds ardur-channel-email (§4.4 Cycle-4 P0 subset: IMAP poll receive + SMTP send behind the MessagingGateway trait, deny-by-default sender allowlist, mirroring the Discord/Telegram adapters) and ardur-web-pwa (§10.14 Phase 1: VAPID keypair + Web Push subscribe/unsubscribe/test HTTP surface, filling the gap the blueprint flags as missing alongside the existing static web-client/ PWA shell). Both are opt-in via ARDUR_CHANNEL_EMAIL / ARDUR_PWA_ENABLED. Since SMTP has no in-place message-edit primitive, the server's streaming reply handler now withholds delivery for non-editable origins until the turn completes, sending exactly one email rather than one per chunk. Teams (msgraph_webhook) is intentionally not built here — plans/4.4 and plans/4.5 sequence it Cycle-5+ P2/P3, gated on buyer demand. Checkpoint: architect/sessions/channel-email-webpwa-2026-07-14/journal.md Signed-off-by: Gnani Nutakki <gnani.nutakki@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| #[test] | ||
| fn builder_requires_non_empty_fields() { | ||
| let err = EmailConfig::builder("", "pw", "imap.example.com", "smtp.example.com") |
|
|
||
| let config = EmailConfig::builder( | ||
| "bot@example.com", | ||
| "pw", |
added 3 commits
July 17, 2026 17:00
Signed-off-by: ArdurAI <team@ardur.ai>
…pwa-2026-07-14 Signed-off-by: ArdurAI <team@ardur.ai>
… drift Signed-off-by: ArdurAI <team@ardur.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ardur-channel-email— §4.4 Cycle-4 P0 subset: IMAP poll receive + SMTP send behind theMessagingGatewaytrait, deny-by-default sender allowlist, mirroring the Discord/Telegram adapters. Opt-in viaARDUR_CHANNEL_EMAIL.ardur-web-pwa— §10.14 Phase 1: VAPID (RFC 8292) keypair + Web Push subscribe/unsubscribe/test HTTP surface, mounted under/pwa. Fills the gap the blueprint flags as missing alongside the existing staticweb-client/PWA shell. Opt-in viaARDUR_PWA_ENABLED.Processor::handle's streaming reply path now withholds delivery for non-editable origins (email) until the turn completes, sending exactly one email rather than one per streamed chunk.msgraph_webhook) is intentionally not built here —plans/4.4andplans/4.5sequence it Cycle-5+ P2/P3, gated on buyer demand; treating it as backlog rather than inventing scope.Test plan
cargo test -p ardur-channel-email— 8 passedcargo test -p ardur-web-pwa— 12 passedcargo test -p ardur-server— full suite green (config/state/routes wiring, streaming reply restructure)cargo test -p ardur-e2e-tests --test scenario_email_channel— stub + gated-live (skips withoutEMAIL_E2E=1)cargo clippy -p ardur-server -p ardur-web-pwa -p ardur-channel-email --all-targets -- -D warnings— cleancargo fmt --checkon all touched crates — clean