Skip to content

Demo lack of error report. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

jgfoster
Copy link
Member

@jgfoster jgfoster commented Apr 5, 2021

Demo of #288

Tests are only run on a PR, so here is one to demo the test failure without an error report.

@ianfixes
Copy link
Collaborator

ianfixes commented Apr 5, 2021

I had to really puzzle this one out, and I'm still not 100% on why the logs weren't getting printed. It looks like the problem is mostly related to mismatching after(:each) with before(:all) -- I was using :all to avoid building the executable multiple times, and I think I have a better solution on my local branch now.

@ianfixes ianfixes mentioned this pull request Apr 5, 2021
@jgfoster
Copy link
Member Author

jgfoster commented Apr 5, 2021

As you will see in #294, I'm very interested in avoiding duplicate compiles. I'm not sure how this ties in but I'm glad you are working on it!

@ianfixes
Copy link
Collaborator

ianfixes commented Apr 5, 2021

I'm curious if this fixes the issue for you locally 22e514d

@jgfoster
Copy link
Member Author

jgfoster commented Apr 5, 2021

In my local macOS environment, this is what I get now:

Unit testing foo.cpp with g++ for uno... 

Last command:  $ g++ -std=c++0x -o /Users/jfoster/Documents/Arduino/arduino_ci/SampleProjects/TestSomething/unittest_foo.cpp.bin -DARDUINO=100 -g -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -fsanitize=address -D__AVR__ -D__AVR_ATmega328P__ -DARDUINO_ARCH_AVR -DARDUINO_AVR_UNO -I/Users/jfoster/Documents/Arduino/arduino_ci/cpp/arduino -I/Users/jfoster/Documents/Arduino/arduino_ci/cpp/unittest -I/Users/jfoster/Documents/Arduino/libraries/TestSomething/src /Users/jfoster/Documents/Arduino/arduino_ci/cpp/arduino/Arduino.cpp /Users/jfoster/Documents/Arduino/arduino_ci/cpp/arduino/Godmode.cpp /Users/jfoster/Documents/Arduino/arduino_ci/cpp/arduino/stdlib.cpp /Users/jfoster/Documents/Arduino/arduino_ci/cpp/unittest/ArduinoUnitTests.cpp /Users/jfoster/Documents/Arduino/libraries/TestSomething/src/test-something.cpp /Users/jfoster/Documents/Arduino/libraries/TestSomething/test/foo.cpp

/Users/jfoster/Documents/Arduino/libraries/TestSomething/test/foo.cpp:6:3: error: use of undeclared identifier 'foo'; did you mean 'for'?
  foo;
  ^~~
  for
/Users/jfoster/Documents/Arduino/libraries/TestSomething/test/foo.cpp:6:6: error: expected '(' after 'for'
  foo;
     ^
2 errors generated.

So that is a useful error report.

@jgfoster
Copy link
Member Author

jgfoster commented Apr 5, 2021

And on a PR, see line 697 of https://github.com/Arduino-CI/arduino_ci/runs/2267056294.

@jgfoster
Copy link
Member Author

jgfoster commented Oct 3, 2021

Demo of failing PR no longer needed so being closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants