pre arm checks: SN number add region parameter

[BluemarkInnovations]

This PR adds:

• region parameter: as each region has different mandatory fields/messages. For instance only in the EU the operator ID messages is mandatory. See https://github.com/opendroneid/opendroneid-core-c#comparison
• performs basic checks whether the entered SN number meets the ANSI/CTA-2063-A standard
• removes the mandatory requirement for the existence of SelfID messages
• Although Japan is added as region, this is not fully compliant as it requires (support) for Auth messages too.
• user can override these checks if Override pre-arm checks #76 is merged and set by the user

[BluemarkInnovations]

@friissoren @tridge @Davidsastresas

Do you have feedback regarding this improved pre-arm check?

In general there are three kind of checks:

• ardupilot
  • will check if the RID module is alive and generate an error if this fails.
  • it will also set the status to emergency in case there is an emergency
• the check_parse function, that checks for valid data.
  • It uses the encode functions of the opendroneID lib for that.
  • In this PR the serial number check is added.
  • And also a region parameter to allow different checks for different regions.
  • would it be useful to add a default valid SN? like ARDU8REM0TE1D The default ABCD123456789 is not accepted by the SN check.
• the arm_status_check function.
  • this checks mostly if new data is still arriving i.e. the timestamp is updated.

There are other PRs that relate a bit to this: #102 and #103

[Davidsastresas]

On QGC front I can accommodate it to whatever you guys do here and in Ardupilot. Just let me know what is necessary and I will include. Thanks!

[tridge]

should use an enum for this

[BluemarkInnovations]

implemented an enum, but it does not compile, need help from @tridge. The enum is not known in the RemoteIDModule.ino. The code also needs a rebase.

[tridge]

@BluemarkInnovations I've restructured this to be cleaner and easier to follow. Please check!

[amilcarlucas]

@BluemarkInnovations any progress on this?

[BluemarkInnovations]

I like the restructuring of the code! Much better now.

I tried to compile this updated code and test it. It compiles, but somehow the parameter list was not shown anymore in DroneCAN GUI tool or MissionPlanner. This limited my tests, but looking to the code, everything seems okay to me.

[BluemarkInnovations]

For now I would set Japan to WORLD. According to this page, two basic ID messages are needed, but also authentication messages. The latter is not implemented in ArduRemoteID. Therefore better to set it to WORLD, otherwise users may assume the firmware is compatible with Japan

[BluemarkInnovations]

Based in on my experience, in some countries of the EU, also a CAA ID is mandatory for companies that fly drones. In those countries: there are 3 mandatory fields for companies: a) Serial Number b) CAA ID (company ID) c) pilot (operator ID). For now I would suggest to leave it as it, as I don't have a good overview or source that lists the requirements per EU country.