Fix: default to zero input when none provided in integrate#52
Open
ftavella wants to merge 1 commit into
Open
Conversation
) When `input` is not specified, `integrate` now defaults to an array of zeros instead of raising a ValueError. Single-input models get a 1D zeros array; multi-input models get a 2D zeros array shaped (len(time), num_inputs). This matches the existing behavior for `initial_condition`. Also fix `pkg_resources` import in setup.py for setuptools >= 82. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18
When
inputis not specified inintegrate(or__call__), the model now defaults to an array of zeros rather than raising aValueError. This makesinputtruly optional, consistent with howinitial_conditionalready works.Changes
integrate: replaceraise ValueErrorwheninput is Nonewith a default ofnp.zeros(len(time))for single-input models andnp.zeros((len(time), num_inputs))for multi-input modelspkg_resourcesimport insetup.pyforsetuptools >= 82compatibilityTests
Updated
test_models.ipynb:ValueErrorwhen no input is providedForger99) withoutinputproduces the same trajectory as passingnp.zerosinputis omitted