Epson V700 Scanner: Add filterable DPI and color-mode columns - #61
Merged
Conversation
Wires up a dedicated `epson_v700_scanner` instrument variant in the web app with filterable DPI (300/600) and Color Mode (RGB/B&W) columns, modeled on the existing qPCR/Hina patterns. Extends the Lambda's TIFF metadata parser to also persist derived `dpi` and `color_mode` keys so filters use the existing JSONB GIN index without bespoke SQL. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated
epson_v700_scannerinstrument variant to the web app with filterable DPI (300/600) and Color Mode (RGB/B&W) columns. Extends the Lambda's TIFF metadata parser to also persist deriveddpiandcolor_modekeys so filters use the existing JSONB GIN index without bespoke SQL.Changes
epson_v700_scanner.image_processing):parse_metadata()now emits deriveddpi(int, computed fromXResolution) andcolor_mode("rgb"/"bw", inferred fromSamplesPerPixelwithPhotometricInterpretationfallback) alongside the raw TIFF tags.0018_epson_v700_scanner_typeaddsepson_v700_scannerto theinstrument_typeenum;0019_set_epson_scanner_typebackfills the existingepson-v700-scannerinstrument row to the new type.lib/api/instrument-runs.ts: newdpi/colorModefilters onbuildRunListQuery, newgetEpsonScannerFilterOptions, and newepson_v700_scannerarm on theInstrumentFilterOptionsByTypediscriminated union.components/instruments/runs-table/epson-scanner-runs-table.tsx) and run-detail variant (components/runs/variants/epson-scanner-run-detail.tsx), plusEpsonScannerRunBadgesinrun-metadata-badges.tsx. Wired into the page-level switch inapp/instruments/[instrumentId]/page.tsxand the run-detail variant index.lib/search-params.ts: newdpiandcolor_modeparseAsStringentries.Epson V700 Scanneradded to the instrument-type dropdown inedit-instrument-dialog.tsx.Breaking changes
None.
Driveby changes
DPI_COLORS,COLOR_MODE_COLORS, andCOLOR_MODE_LABELSconstants inlib/instrument-colors.ts.Testing
make check-all(Python + frontend lint/format/typecheck)_derive_dpi,_derive_color_mode, andparse_metadataderived fields (300/600 DPI, RGB/B&W)SELECT enumlabel FROM pg_enum WHERE enumtypid = 'public.instrument_type'::regtype).tifto staging and confirm DPI / Color Mode render in the runs table and run-detail metadata block