Fix DishCam sidecar completion and batch encode disk use - #198
Merged
Conversation
The sidecar has no TIFF of its own, so reprocess left it in processing and the run never left that state even after the MP4 was uploaded. Co-authored-by: Cursor <cursoragent@cursor.com>
…stacks. A run.json invoke encoded every TIFF without deleting local files, so the 10 GB Lambda disk filled after a few high-quality stacks. The batch also reset completed siblings to processing, then marked them failed. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
A corrected run.json now updates the run even when every stack is skipped. An unreadable sidecar (and its stacks) goes through processing before failed. Completing the sidecar no longer hides an encode error. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run.jsoncompleted after it parses, even if a stack failed, so a reprocess does not leave the sidecar (and the run) stuck in processing. The run still shows failed when a stack failed.run.jsonstill updates the run.run.json(and its stacks) throughprocessingfirst — the API does not allowuploaded→failed.run.jsonencodes every stack in one invoke, skip stacks that are already completed or processing so a later disk-full error cannot reopen a sibling's success and mark it failed. A stack left inprocessingafter a timeout is retried by reprocessing that TIFF./tmpcap.Test plan
uv run pytest lambda/tests/dishcam/test_process_file.pyrun.jsonleaves processing[Errno 28] No space left on deviceMade with Cursor