Skip to content

Make max stability wait configurable - #162

Merged
wasimxyz merged 2 commits into
stagingfrom
watcher-configurable-max-stability-wait
Jul 21, 2026
Merged

Make max stability wait configurable#162
wasimxyz merged 2 commits into
stagingfrom
watcher-configurable-max-stability-wait

Conversation

@wasimxyz

@wasimxyz wasimxyz commented Jul 21, 2026

Copy link
Copy Markdown
Member

Summary

  • Add instrument.max_stability_wait_seconds (default 300, range 1–86400, must be ≥ stability_period_seconds) so the hard-coded 5-minute abandon timeout is configurable in watcher YAML.
  • Wire the setting through FileMonitor / runtime; stability_timeout events report the configured max_wait_seconds.
  • Bump watcher to 0.5.4 and update developer docs.
  • Fix stale web-app docs links (set-up-an-instrument, manage-tokens, overview) broken by the docs-site restructure — including "Open setup guide" in the Add instrument modal.

Test plan

  • Unit tests for config validation (bounds + cross-field rule) and custom max wait on the monitor
  • make check-all
  • Confirm a config with max_stability_wait_seconds: 600 loads and is used on abandon
  • Confirm existing configs without the field keep the 300s default
  • Click "Open setup guide" and "Get a token" in the Add instrument modal; confirm both resolve
  • Click "Quickstart" on the login screen; confirm it opens /docs/overview

Expose instrument.max_stability_wait_seconds so operators can raise the
abandon timeout for long-writing instruments without a code change.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
data-hub Ready Ready Preview, Comment Jul 21, 2026 6:34pm

Request Review

@wasimxyz wasimxyz self-assigned this Jul 21, 2026
@wasimxyz wasimxyz changed the title Make max stability wait configurable (watcher 0.5.4) Make max stability wait configurable Jul 21, 2026
Point Add instrument / Quickstart / token links at the current
set-up-an-instrument, overview, and manage-tokens slugs.

Co-authored-by: Cursor <cursoragent@cursor.com>
@wasimxyz
wasimxyz merged commit 2ab5fc4 into staging Jul 21, 2026
6 checks passed
@wasimxyz
wasimxyz deleted the watcher-configurable-max-stability-wait branch July 21, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant