Skip to content

Point docs links at datahub.arcadiascience.com/docs - #130

Merged
wasimxyz merged 1 commit into
stagingfrom
fix/docs-site-links
Jul 8, 2026
Merged

Point docs links at datahub.arcadiascience.com/docs#130
wasimxyz merged 1 commit into
stagingfrom
fix/docs-site-links

Conversation

@wasimxyz

@wasimxyz wasimxyz commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

The docs site now serves under /docs on the product's domain via Vercel Microfrontends (#128, Arcadia-Science/data-hub-docs#5), so this moves every reference off the old arcadia-data-hub-docs.vercel.app deployment and fixes two link bugs that surfaced after the move.

  • Repoint the docs host in the READMEs, AGENTS.md, developer-docs/, and the watcher package metadata to https://datahub.arcadiascience.com/docs. Home links now target /docs (the docs landing) rather than the apex, which is the product.
  • Make the docs origin client-safe. web/lib/docs.ts now reads NEXT_PUBLIC_DOCS_BASE_URL so it inlines into the client bundle. The Docs link in the sidebar user menu is a Client Component, where the old non-public DOCS_BASE_URL resolved to undefined and silently fell back to the hardcoded URL — which is why setting the env var in Vercel had no effect.
  • Add DOCS_URL (<origin>/docs) for the bare "Docs" links, which otherwise pointed at the product root after the domain move, and fix the login page's Quickstart link to /docs/quickstart (getting-started doesn't exist). adding-an-instrument and managing-tokens were verified against the docs content.

The two microfrontends.json development.fallback values were intentionally left as arcadia-data-hub-docs.vercel.app — those are functional local-dev routing config pointing at the docs child's own deployment.

Follow-up (dashboard, not code)

  • Rename the Vercel env var DOCS_BASE_URLNEXT_PUBLIC_DOCS_BASE_URL (same value) and redeploy so it can override the fallback. The fallback is already correct, so links work without it.

Test plan

  • make check-all
  • Sidebar user-menu Docs link opens https://datahub.arcadiascience.com/docs
  • Login page Docs/docs, Quickstart/docs/quickstart (both resolve, no 404)

Made with Cursor

The docs site now serves under /docs on the product's domain via Vercel
Microfrontends, so move all references off the old
arcadia-data-hub-docs.vercel.app deployment.

- Swap the docs-site host in the READMEs, AGENTS.md, developer-docs, and the
  watcher package metadata to https://datahub.arcadiascience.com/docs.
- Source the docs origin from NEXT_PUBLIC_DOCS_BASE_URL so it inlines into the
  client bundle: the Docs link in the sidebar user menu is a Client Component,
  where the old non-public DOCS_BASE_URL resolved to undefined and silently
  fell back to the hardcoded URL.
- Add DOCS_URL (<origin>/docs) for the bare "Docs" links, which otherwise
  pointed at the product root after the domain move, and fix the login page's
  Quickstart link to /docs/quickstart (getting-started doesn't exist).

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
data-hub Ready Ready Preview, Comment Jul 8, 2026 6:35pm

Request Review

@wasimxyz wasimxyz self-assigned this Jul 8, 2026
@wasimxyz
wasimxyz merged commit ee03ebd into staging Jul 8, 2026
5 checks passed
@wasimxyz
wasimxyz deleted the fix/docs-site-links branch July 8, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant