Point docs links at datahub.arcadiascience.com/docs - #130
Merged
Conversation
The docs site now serves under /docs on the product's domain via Vercel Microfrontends, so move all references off the old arcadia-data-hub-docs.vercel.app deployment. - Swap the docs-site host in the READMEs, AGENTS.md, developer-docs, and the watcher package metadata to https://datahub.arcadiascience.com/docs. - Source the docs origin from NEXT_PUBLIC_DOCS_BASE_URL so it inlines into the client bundle: the Docs link in the sidebar user menu is a Client Component, where the old non-public DOCS_BASE_URL resolved to undefined and silently fell back to the hardcoded URL. - Add DOCS_URL (<origin>/docs) for the bare "Docs" links, which otherwise pointed at the product root after the domain move, and fix the login page's Quickstart link to /docs/quickstart (getting-started doesn't exist). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docs site now serves under
/docson the product's domain via Vercel Microfrontends (#128, Arcadia-Science/data-hub-docs#5), so this moves every reference off the oldarcadia-data-hub-docs.vercel.appdeployment and fixes two link bugs that surfaced after the move.AGENTS.md,developer-docs/, and the watcher package metadata tohttps://datahub.arcadiascience.com/docs. Home links now target/docs(the docs landing) rather than the apex, which is the product.web/lib/docs.tsnow readsNEXT_PUBLIC_DOCS_BASE_URLso it inlines into the client bundle. The Docs link in the sidebar user menu is a Client Component, where the old non-publicDOCS_BASE_URLresolved toundefinedand silently fell back to the hardcoded URL — which is why setting the env var in Vercel had no effect.DOCS_URL(<origin>/docs) for the bare "Docs" links, which otherwise pointed at the product root after the domain move, and fix the login page's Quickstart link to/docs/quickstart(getting-starteddoesn't exist).adding-an-instrumentandmanaging-tokenswere verified against the docs content.The two
microfrontends.jsondevelopment.fallbackvalues were intentionally left asarcadia-data-hub-docs.vercel.app— those are functional local-dev routing config pointing at the docs child's own deployment.Follow-up (dashboard, not code)
DOCS_BASE_URL→NEXT_PUBLIC_DOCS_BASE_URL(same value) and redeploy so it can override the fallback. The fallback is already correct, so links work without it.Test plan
make check-allhttps://datahub.arcadiascience.com/docs/docs, Quickstart →/docs/quickstart(both resolve, no 404)Made with Cursor