Fix .gitignore entries that weren't being parsed. Fix inconsistent indenting and whitespace. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…denting and whitespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there - while reading through the code I kept tripping over spacing inconsistencies that made it distracting to read through. I've updated spacing and indenting to be consistent with the PEP8 standard. The logic of the code remains unchanged. I did not review the contents of code cells in the Jupyter notebook for formatting inconsistencies.
Also, the .gitignore looked to have been copied in from somewhere that introduced a preceding
-string to each line (aside from the custom lines at the bottom), rendering the entries unusable. I've fixed these lines so nowvirtualenvdirectories, compiled Python files, etc. will not be included in future git commits. I did take the liberty of adding an Intellij-specific ignore rule for the.idea/preferences directory as is standard practice.Do let me know if I can answer any questions, or if splitting this into separate PRs will help given that the size of the change is not trivial.
All the best,
Joe.