Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+Windows Services & Standalone apps instrumentation #18

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thiru-chidambaram
Copy link
Contributor

+Windows Services & Standalone apps instrumentation

…lthMonitoring

Dot net agent recipe  - Installing using windows cookbook & IIS automatic instrumentation
+Windows Services & Standalone apps instrumentation
…tation

+Windows Services & Standalone apps instrumentation
@@ -3,6 +3,6 @@
default['appdynamics']['dotnet_agent']['checksum'] = '7acb3756147a1d5a13c49b107a890ea56a8eb4099fd793e498e34b6f0b5962dc' #nil
default['appdynamics']['dotnet_agent']['install_dir'] = 'C:\Program Files\Appdynamics'
default['appdynamics']['dotnet_agent']['logfiles_dir'] = 'C:\DotNetAgent\Logs'

default['appdynamics']['dotnet_agent']['standalone_apps'] = nil #'a.exe,b.exe'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does comma separated make sense here? Why not take an array?

default['appdynamics']['dotnet_agent']['standalone_apps'] = ['a.exe', 'b.exe']

Then you don't have to split in the template.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - thats fine too. I just wanted to keep the attributes simple.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there are multiple exe's like a.exe & b.exe both will end up with the same app_name/tier_name in the controller even though they are different exe's. can we change the standalone_apps to an array that includes the 3 possible properties? standalone-application executable, command-line, and tier name

example config from the docs

    <standalone-applications>
        <standalone-application executable="MyWindowsService.exe" command-line="-x">
           <tier name="Windows Service Tier" />
        </standalone-application>
        <standalone-application executable="MyStandaloneApp.exe">
           <tier name="Standalone Tier" />
        </standalone-application>
    </standalone-applications>

https://docs.appdynamics.com/display/PRO41/Instrument+Windows+Services+and+Standalone+Applications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants