Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort hint text typo #2050

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

ThePrimeJnr
Copy link
Contributor

Description:

This pull request fixes the bug reported in issue #2044 where the hint text under the sort feature was misplaced. The expected behavior was to display "Sort by" in the hint text, but instead, it was displaying "Filter by".

Type of change:

I fixed the bug by simply correcting the code, replacing "filterBy" with "sortBy" which references the correct hint text.
fixes #2044

@a-wallen
Copy link
Contributor

a-wallen commented Mar 21, 2023

@DestinedCodes, this PR is test-exempt! :)

@a-wallen a-wallen merged commit 0162af8 into AppFlowy-IO:main Mar 21, 2023
@ThePrimeJnr ThePrimeJnr deleted the fix/sort_hint_text_typo branch March 21, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] hint text misplaced
2 participants