Add components #12
Add components #12
Conversation
lerna-debug.log
Outdated
| @@ -0,0 +1,22 @@ | |||
| 0 silly argv { _: [ 'run' ], | |||
There was a problem hiding this comment.
I don't know much about lerna - but this sounds like a file that shouldn't be added to git.
There was a problem hiding this comment.
@christiemolloy Can you remove this log file. Should update the .gitignore to not check in .log files as well.
There was a problem hiding this comment.
Removed and updated gitignore
|
Are *.tsx files just typescript files? Have I been naming my typescript files incorrectly all this time? :) |
|
I fixed up the Keycloak problems. You can see that in this PR: #14 So you should be able to restore the keycloak stuff in this PR. |
lerna-debug.log
Outdated
| @@ -0,0 +1,22 @@ | |||
| 0 silly argv { _: [ 'run' ], | |||
There was a problem hiding this comment.
@christiemolloy Can you remove this log file. Should update the .gitignore to not check in .log files as well.
packages/studio/src/app/app.css
Outdated
| @@ -16,4 +16,84 @@ | |||
| .pf-c-page { | |||
| width: 100%; | |||
| height: 100vh; | |||
| } | |||
|
|
|||
| .pf-c-page__main-section { | |||
There was a problem hiding this comment.
.pf-c stuff are also found in patternfly right? Instead of overriding the classes should we create new classes and set set these modifications in those classes? For example create a appicurio-page_main-section class with these settings. We did that in integreatly which seemed like a good approach.
There was a problem hiding this comment.
Yeah I think thats a great idea thanks for pointing that out!
packages/studio/src/app/app.tsx
Outdated
| > | ||
| {section} | ||
| <Route path='/' exact={true} component={Pages.Dashboard}/> |
There was a problem hiding this comment.
We should open a Jira issue to have Lucia design a route for page not found. We need an elegant way to handle 404.
There was a problem hiding this comment.
packages/studio/src/app/appCard.tsx
Outdated
| import './app.css' | ||
|
|
||
| type AppCardProps = { | ||
| apiName: string, |
There was a problem hiding this comment.
I don't believe all these props are required. We should change these to match the props in the model so it will map 1 to 1 when retrieve this from the server.
interface AppCardProps { name: string, description: string, tags?: string[] }
There was a problem hiding this comment.
Yep updating these now that I know which models we're using!
| @@ -0,0 +1,40 @@ | |||
| { | |||
| "apis": [ | |||
There was a problem hiding this comment.
Create a bug to move this out of studio into a package called mock under packages. We can then include it in as a package under devDependencies. This way we won't add unnecessary mock data files to the studio package.
There was a problem hiding this comment.
Created this issue #15
packages/studio/src/app/appTabs.tsx
Outdated
| </Tabs> | ||
| <div> | ||
| <TabContent eventKey={0} id="refTab1Section" ref={this.contentRef1} aria-label="Tab item 1"> | ||
| {this.props.date} |
There was a problem hiding this comment.
date and author are not defined in the AppTabsProps.
| }; | ||
|
|
||
| render() { | ||
| return ( |
There was a problem hiding this comment.
Can you update this to destructure the props object.
| import { Breadcrumb, BreadcrumbItem, Button, Form, FormGroup, TextInput, TextArea, FormSelectOption, FormSelect, Checkbox, ActionGroup, Radio, Title, PageSection, PageSectionVariants } from '@patternfly/react-core'; | ||
| import '../../app.css' | ||
|
|
||
| type CreateApiProps = { |
| type CreateApiProps = { | ||
| } | ||
|
|
||
| type CreateApiState = { |
| @@ -3,27 +3,27 @@ import ReactDOM from "react-dom"; | |||
| import "@patternfly/react-core/dist/styles/base.css"; | |||
| import App from './app/app'; | |||
There was a problem hiding this comment.
you can undo these change and rebase to get the latest fix for keycloak.
|
This still says "WIP" so just let me know when you want it merged. |
|
Need to resolve conflicts first. :) |
Add components to the UI: