Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Select component with NativeSelect component #27

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

yuki-js
Copy link
Member

@yuki-js yuki-js commented Oct 20, 2024

Fixes #26

Replace the Select component with the NativeSelect component in SelectWidget.tsx.

  • Import Statement

    • Update import statement to import NativeSelect from @mantine/core.
  • Component Replacement

    • Replace Select component with NativeSelect component.
    • Adjust the handleChange function to handle the NativeSelect value.
  • Remove Unnecessary Props

    • Remove searchable, onDropdownClose, and onDropdownOpen props from NativeSelect.

For more details, open the Copilot Workspace session.

Fixes #26

Replace the `Select` component with the `NativeSelect` component in `SelectWidget.tsx`.

* **Import Statement**
  - Update import statement to import `NativeSelect` from `@mantine/core`.

* **Component Replacement**
  - Replace `Select` component with `NativeSelect` component.
  - Adjust the `handleChange` function to handle the `NativeSelect` value.

* **Remove Unnecessary Props**
  - Remove `searchable`, `onDropdownClose`, and `onDropdownOpen` props from `NativeSelect`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/AokiApp/rjsf-mantine-theme/issues/26?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

cloudflare-workers-and-pages bot commented Oct 20, 2024

Deploying rjsf-mantine-theme with  Cloudflare Pages  Cloudflare Pages

Latest commit: 936b788
Status: ✅  Deploy successful!
Preview URL: https://f4ef03a5.rjsf-mantine-theme.pages.dev
Branch Preview URL: https://yuki-js-replace-select-with.rjsf-mantine-theme.pages.dev

View logs

@yuki-js yuki-js marked this pull request as ready for review October 21, 2024 15:44
@yuki-js yuki-js merged commit 727ce90 into main Oct 22, 2024
2 checks passed
@yuki-js yuki-js deleted the yuki-js/replace-select-with-nativeselect branch October 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select -> NativeSelect
1 participant