Sensing heat#12191
Open
cardillan wants to merge 2 commits into
Open
Conversation
Contributor
|
how does this interact with nuclear reactor heat? it is primordial it does not reach values >1 to not break serpulo logic |
Contributor
Author
It doesn't change the |
Contributor
|
I see now, HeatBlock is unchanged (nuclear reactor implements it) so sensing is (or should be) exactly the same. My concern was sensor heat returning values >1, as heatFrac()/heatOutput can reach up to 15. This would ve broken quite a lot of basic serpulo logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt at implementing Anuken/Mindustry-Suggestions#6353.
As there isn't a
heatfield common to all blocks, I've added the ability to sense@heatto blocks that define the field, returning the value of the field as-is. Apparently, different blocks use different ranges for heat, so maybe adding a@heatCapacityor@maxHeatproperty might be useful, but I didn't want to go there as I don't understand the mechanism all that much. It should still be useful for map authors using world processors as it is.If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: