drawNoise/drawNoiseLayers as an effect so that json can use them#12152
Open
EggleEgg wants to merge 5 commits into
Open
drawNoise/drawNoiseLayers as an effect so that json can use them#12152EggleEgg wants to merge 5 commits into
EggleEgg wants to merge 5 commits into
Conversation
Contributor
|
YO, I'VE AN IDEA |
Anuken
reviewed
May 30, 2026
|
|
||
| @Override | ||
| public void render(EffectContainer e){ | ||
| Texture tex = Core.assets.get(noisePath, Texture.class); |
Owner
There was a problem hiding this comment.
If you look at the source for get, you'll see that libGDX did something really funny by making it crash instead of return null when the file isn't found. This is obviously a bad idea for effects. I'm adding a getOrNull method to fix this, but this PR will have to wait until that's merged in.
Also, it should be cached so that it only needs to call getOrNull the first time instead of calling it every render.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example with a datapatch:
2026-05-30.13-11-58.mp4
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: