Skip to content

Assignment 2#3

Open
AnthoniaAina wants to merge 4 commits intomainfrom
assignment_2
Open

Assignment 2#3
AnthoniaAina wants to merge 4 commits intomainfrom
assignment_2

Conversation

@AnthoniaAina
Copy link
Owner

@AnthoniaAina AnthoniaAina commented Oct 28, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding code to complete the assignment

What did you learn from the changes you have made?

I still need to practice more

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

I also do not understand why my last code still keeps outputting "None".

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@tianyi21 tianyi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anthonia,

✅ You implemented the function to read and display a file.
✅ You completed the patient_summary() function to summarize a file.
⚠️ You implemented the detect_problems() function to check the file.

⚠️ In the first version of your detect_problems() function, you implemented the correct way to check if a file contains all-zero rows. However, as specified in the question statement, the function’s output should be a Boolean variable (either True or False) instead of a printout. The second version of your detect_problems() function checks if the minimum or maximum of rows in a given file is 0. While the max case may work for this specific data, the min case doesn’t necessarily mean the row is all-zero.

Please revise your current submission to address the ⚠️ issue(s).

Thanks,
Tianyi [LS]

Copy link

@tianyi21 tianyi21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for revising your submission.

🎉 Your A2 is complete!
🎊 All your Python assessments are now complete. Thank you for your participation, and I wish you all the best for your future!

Thanks,
Tianyi [LS]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants