Conversation
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Question 1: (ii) 'class' is categorical variable. Therefore , it should not be standardized. Standardization only makes sense for numeric, continuous variables.
Question 2: (iv) You have to use standardized data (predictors_standardized) instead of actual data (wine_df) for generating the training and testing set. Please correct that.
Also. instead of using Wine_train, Wine_test = train_test_split(..., try using
X_train, X_test, y_train, y_test = train_test_split(...
That way, it will be easier for you to call subsequent function calls namely, fit and predict.
Question 4 has some runtime errors. Please feel free to get assistance from Learning support during work periods if you need help fixing the errors
|
A friendly reminder to complete the requested review changes for assignment 1. Thank you. |
|
Anthonia, Some of the requested review changes have not been made.
GridSearchCV expects an unfitted estimator and will clone it internally. Giving it a previously fitted knn does not break, but is misleading. COrrect usage is:
|
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Please make the requested changes. Thank you.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Submitting Assignment 1 for LCR
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
I ran the code in visual studio
A reference to a related issue in your repository (if applicable)
Checklist