Merged
Conversation
flomnes
reviewed
Jul 11, 2025
| from ..model.general_data import GeneralData | ||
|
|
||
|
|
||
| def _upgrade_thematic_trimming(data: GeneralData) -> None: |
Member
There was a problem hiding this comment.
This method is quite complex and should be unit-tested
- Build a
GeneralDataobject in-memory - Apply this method
- Check the resulting
GeneralDataobject
flomnes
previously approved these changes
Jul 11, 2025
MartinBelthle
requested changes
Jul 11, 2025
Contributor
MartinBelthle
left a comment
MartinBelthle
left a comment
There was a problem hiding this comment.
1 real remark, the rest is really minor
Contributor
There was a problem hiding this comment.
You didn't change the version inside the study.antares file
This reverts commit 0d48ea7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.