Skip to content

[WIP] PR Workflow #68

Open
nikolaredstork wants to merge 2 commits intomainfrom
feature/pr-lifecycle-workflow
Open

[WIP] PR Workflow #68
nikolaredstork wants to merge 2 commits intomainfrom
feature/pr-lifecycle-workflow

Conversation

@nikolaredstork
Copy link
Collaborator

@nikolaredstork nikolaredstork commented Mar 9, 2026

This PR introduces Pull-Request Lifycycle Workflow Management with following rules and steps:

  • 1. Development Starting Point
  • 2. Branch Management System
  • 3. Pull Request Creation Rules
  • 4. Pull Request Description Rules
  • 5. Pull Request Labeling Convention
  • 6. Review Rules
  • 7. Merge Rules
  • 8. Release Branch Rules
  • 9. Tagging Rules
  • 10. Versioning Rule
  • 11. Changelog Rule
  • 12. Python Package Rules ?
  • 13. Hotfix Rules
  • 14. Rollback Rules
  • 15. CI/CD Rules
  • 16. Recommended Minimal PR Lifecycle

@nikolaredstork nikolaredstork requested a review from aoustry March 9, 2026 13:14
@nikolaredstork nikolaredstork changed the title [WIP] PR Workflow PR Workflow Mar 16, 2026
Comment on lines +9 to +12
- GEMS Language
- GemsPy
- Antares2GEMS Converter
- PyPSA2GEMS Converter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give the URL of the concerned repos

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!


# 1. Development Starting Point

All changes **MUST start from a tracked GitHub Issue**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should precise/discuss where the GitHub Issue should be written. My opinion: each repo should own its GitHub issues.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that's the plan!

The issue **MUST include**:

- purpose of the change
- affected repository or repositories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this a responsibility of the GitHub issue writer to enumerate impacts on other repos. It can help, but it is not mandatory and we shouldn't expect this for any GitHub issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge last expected impact and compatibility impact

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

affected repository or repositories is excluded

## Scope
List affected components, modules, or repositories.

## Compatibility Impact
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my remark above: I am not sure this is the reponsibility of a repo to warn the downstream repo. This is rather the responsibility of each repo to "observer" the upstream repo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, repositories are excluded, but we will still have compatibility impact.

@nikolaredstork nikolaredstork requested a review from aoustry March 19, 2026 17:43
@nikolaredstork nikolaredstork changed the title PR Workflow [WIP]PR Workflow Mar 20, 2026
@nikolaredstork nikolaredstork changed the title [WIP]PR Workflow [WIP] PR Workflow Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants