(PR33) Documentation/Tutorial_1_Unit_Commitment (jupyter notebook)#67
Open
GuillaumeMaistre wants to merge 18 commits intodevelopfrom
Open
(PR33) Documentation/Tutorial_1_Unit_Commitment (jupyter notebook)#67GuillaumeMaistre wants to merge 18 commits intodevelopfrom
GuillaumeMaistre wants to merge 18 commits intodevelopfrom
Conversation
Collaborator
Author
|
I added a new environment ; the tutorial_environment containing the needed libraries for running this jupyter notebook (especially GEMSPy) |
aoustry
requested changes
Mar 10, 2026
Contributor
aoustry
left a comment
There was a problem hiding this comment.
General comments :
- Could avoid duplicating the library of models ?
- please rename the folder "QSE_2_Unit_Commitment_tutorial" into "Tutorial_Unit_Commitment_with_GemsPy". In any case, please avoid the reference to the QSE example, a bit misleading.
- Is it really a need to create an "input" folder in the Github repo, below the aforementioned folder?
- How can we access to this tutorial from the GEMS website ? Where do you suggest to place the tutorial in the website.
- Please add "Spilled energy" to the Figures.
Contributor
There was a problem hiding this comment.
Why duplicating this file? Couldn't we just use the antares_legacy_models library from the reference folder ?
Collaborator
Author
There was a problem hiding this comment.
because we need to add expec function
Contributor
There was a problem hiding this comment.
I suggest deleting this file, since the system is created from scratch with GemsPy
Collaborator
Author
There was a problem hiding this comment.
I deleted them
Contributor
There was a problem hiding this comment.
I have several comments on the Jupyter Notebook:
- "This tutorial shows the different commands for using GEMSPy python package for modeling and simulating an Unit Commitment problem." => Add link to GemsPy
- "We use in this tutorial the library, antares-legacy-models, present in GEMS repo" => "We use in this tutorial the reference library of models called antares-legacy-models"
- "An area is the central node in the electrical grid where different components connect." => "In the library of models used here, an area is a component representing an energy balance constraint ; several types of components (production, load, storage, links...) might be connected to it."
- Use € rather than $
- Labels in the three Graphs "Thermal Generation and... etc" : "Thermal" => "Thermal Generation", "Unsupply" => "Unsupplied" energy.
- "The wind_farm has a fluctuated power generation" => "The wind_farm has a variable power generation" and same for solar_farm.
- Results visualization : why load, wind and farm are not printed?
- "Interconnect Wind Farm and Solar Farm" => "Add Variable Renewable Energies in the system"
- In the last section, can you add positive starting_cost and fixed_cost to the thermal cluster ? (ex: 20€ and 10 € respectively). This will force the UC to be a bit more realistic. Please don't forget to add this in the description paragraph above the code.
- nb_units_max_variation_forward and nb_units_max_variation_backward should be equal to nb_units_max for both thermal clusters created.
Collaborator
Author
There was a problem hiding this comment.
- "This tutorial shows the different commands for using GEMSPy python package for modeling and simulating an Unit Commitment problem." => Add link to GemsPy
- "We use in this tutorial the library, antares-legacy-models, present in GEMS repo" => "We use in this tutorial the reference library of models called antares-legacy-models"
- "An area is the central node in the electrical grid where different components connect." => "In the library of models used here, an area is a component representing an energy balance constraint ; several types of components (production, load, storage, links...) might be connected to it."
- Use € rather than $
- Labels in the three Graphs "Thermal Generation and... etc" : "Thermal" => "Thermal Generation", "Unsupply" => "Unsupplied" energy.
- "The wind_farm has a fluctuated power generation" => "The wind_farm has a variable power generation" and same for solar_farm.
- Results visualization : why load, wind and farm are not printed?
- "Interconnect Wind Farm and Solar Farm" => "Add Variable Renewable Energies in the system"
- In the last section, can you add positive starting_cost and fixed_cost to the thermal cluster ? (ex: 20€ and 10 € respectively). This will force the UC to be a bit more realistic. Please don't forget to add this in the description paragraph above the code.
- nb_units_max_variation_forward and nb_units_max_variation_backward should be equal to nb_units_max for both thermal clusters created.
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is under progress and it is not ready to be reviewed
This PR has the following changes :