Skip to content

Remove member function Study::areaAdd [ANT-4815]#3527

Open
YoshuaLisasi wants to merge 1 commit intodevelopfrom
fix/ANT-4815-remove-member-function-study-areaAdd
Open

Remove member function Study::areaAdd [ANT-4815]#3527
YoshuaLisasi wants to merge 1 commit intodevelopfrom
fix/ANT-4815-remove-member-function-study-areaAdd

Conversation

@YoshuaLisasi
Copy link
Collaborator

  • Remove the function
  • Transform loadListFromFile to allow a call to addAreaToListOfAreas
  • move the case lname empty to AreaListAddFromNames (because duplicate code)
  • remove CheckForbiddenCharacterInAreaName, useless (due to previous call of transformNameIntoID)
  • Replace calls to areaAdd in tests by calls to addAreaToListOfAreas

Possible follow ticket : Area::createMissingData and Area::resetToDefaultValues are unused. Can they be removed safely ?

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
23.1% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant