Time sum with literals : forgotten fixes required by review#3505
Closed
guilpier-code wants to merge 1 commit intodevelopfrom
Closed
Time sum with literals : forgotten fixes required by review#3505guilpier-code wants to merge 1 commit intodevelopfrom
guilpier-code wants to merge 1 commit intodevelopfrom
Conversation
|
guilpier-code
changed the title
Member
|
I prefer the previous version with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply some non pushed fixes due to remarks made by a reviewer (@flomnes) on closed PR 3464.
In the initial PR, I replied to remarks saying I made the required fixes. But I never pushed them eventually, until now.