Draft
Conversation
… to ensure reproducibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a clear policy for managing the version of the
Antares_Simulator_Tests_NRsubmodule in CI workflows, ensuring reproducibility for releases while providing developers with up-to-date test data during development. The workflows for both Ubuntu and Windows now initialize the submodule differently based on whether the run is a release or a development build. Additionally, an Architecture Decision Record (ADR) documents this strategy for future maintainers.Submodule management improvements:
.github/workflows/ubuntu.ymland.github/workflows/windows-vcpkg.yml) now initialize theAntares_Simulator_Tests_NRsubmodule to the recorded commit for release builds, and to the latestmainbranch for development builds, ensuring reproducibility and developer convenience. [1] [2]src/tests/resources/Antares_Simulator_Tests_NRhas been updated to a new commit, reflecting the latest test data.Documentation:
docs/Architecture_Decision_Records/2025-03-02-submodule-version-pinning.md) describing the rationale, implementation details, and consequences of the new submodule management policy.