feat: add legacy data simulation table support#3373
Draft
JasonMarechal25 wants to merge 5 commits intodevelopfrom
Draft
feat: add legacy data simulation table support#3373JasonMarechal25 wants to merge 5 commits intodevelopfrom
JasonMarechal25 wants to merge 5 commits intodevelopfrom
Conversation
Contributor
JasonMarechal25
commented
Jan 28, 2026
- Write legacy output in simulation table
- Ex :
added 4 commits
January 27, 2026 13:55
* Introduce LegacySimulationTableOptions struct for managing legacy simulation table configurations. * Update exportSurveyResults and internalExportAnnualValues methods to accept legacy options. * Implement configureLegacySimulationTable and clearLegacySimulationTable methods in SurveyResults. * Enhance legacyComponentId to support new data structure.
* Introduced writeSimulationTable method in Adequacy and Economy classes. * Refactored simulation table writing logic to improve code reuse. * Updated simulationBegin method to utilize the new writeSimulationTable method.
* Added checks to skip indices outside the defined range limits. * Implemented filtering for zero values in the simulation table.
Contributor
Author
* Add parsing for legacy variable names. * Implement FillLegacySimulationTable function. * Integrate legacy simulation table filling into the existing workflow.
|
a-zakir
reviewed
Jan 28, 2026
| } | ||
|
|
||
| namespace | ||
| { |
Contributor
There was a problem hiding this comment.
Changes in this file are good, you integrate legacy variables in the simulation table.
Let’s discuss on this in dedicated pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

