Skip to content

feat: add legacy data simulation table support#3373

Draft
JasonMarechal25 wants to merge 5 commits intodevelopfrom
feature/legacy_in_ST
Draft

feat: add legacy data simulation table support#3373
JasonMarechal25 wants to merge 5 commits intodevelopfrom
feature/legacy_in_ST

Conversation

@JasonMarechal25
Copy link
Contributor

  • Write legacy output in simulation table
  • Ex :
1,west,MRG. PRICE,166,166,0,0.000587561044500953,None
1,west,MRG. PRICE,167,167,0,0.000587564795839379,None
1,west,MRG. PRICE,168,168,0,0.000587554157726745,None
1,west,CO2 EMIS.,1,1,0,2420,None
1,west,CO2 EMIS.,2,2,0,931,None
1,west,CO2 EMIS.,3,3,0,244,None
1,all areas,OP. COST,164,164,0,0,None
1,all areas,OP. COST,165,165,0,0,None
1,all areas,OP. COST,166,166,0,0,None
1,all areas,OP. COST,167,167,0,0,None
1,all areas,OP. COST,168,168,0,0,None
1,all areas,MRG. PRICE,1,1,0,29.9994564043945,None
1,all areas,MRG. PRICE,2,2,0,29.9994563953735,None
1,all areas,MRG. PRICE,3,3,0,29.9994564011242,None
1,all areas,MRG. PRICE,4,4,0,29.9994564079203,None
1,all areas,MRG. PRICE,5,5,0,29.9994564012318,None

Jason Marechal added 4 commits January 27, 2026 13:55
* Introduce LegacySimulationTableOptions struct for managing legacy simulation table configurations.
* Update exportSurveyResults and internalExportAnnualValues methods to accept legacy options.
* Implement configureLegacySimulationTable and clearLegacySimulationTable methods in SurveyResults.
* Enhance legacyComponentId to support new data structure.
* Introduced writeSimulationTable method in Adequacy and Economy classes.
* Refactored simulation table writing logic to improve code reuse.
* Updated simulationBegin method to utilize the new writeSimulationTable method.
* Added checks to skip indices outside the defined range limits.
* Implemented filtering for zero values in the simulation table.
@JasonMarechal25
Copy link
Contributor Author

* Add parsing for legacy variable names.
* Implement FillLegacySimulationTable function.
* Integrate legacy simulation table filling into the existing workflow.
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
49.4% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

}

namespace
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are good, you integrate legacy variables in the simulation table.
Let’s discuss on this in dedicated pr

@JasonMarechal25 JasonMarechal25 changed the title feat(survey): add legacy simulation table options support feat: add legacy simulation table options support Jan 29, 2026
@JasonMarechal25 JasonMarechal25 changed the title feat: add legacy simulation table options support feat: add legacy data simulation table support Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants