Feature/reserve model lot3 scalian by h-fournier · Pull Request #2575 · AntaresSimulatorTeam/Antares_Simulator

h-fournier · 2025-01-13T15:29:31Z

Add the reserves to the simulator.
Thermal clusters, Short term storage and Long Term storage can participate to the reserves

From @guilpier-code (reviewer) :
Have in mind that Antares Simulator is a legacy code.
It contains very poor historic code that we try to improve any time we can.
So Antares Simulator team can ask for better code quality where the surrounding code is poor.
You're not supposed to know that (something should have been done to inform Scalian sooner).

sonarqubecloud · 2025-04-04T09:44:32Z

Quality Gate failed

Failed conditions
9.4% Coverage on New Code (required ≥ 60%)
18.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

sonarqubecloud · 2025-05-19T10:55:28Z

Quality Gate failed

Failed conditions
9.4% Coverage on New Code (required ≥ 60%)
18.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

src/libs/antares/study/include/antares/study/parameters.h

src/solver/variable/CMakeLists.txt

.github/workflows/windows-vcpkg.yml.orig

src/antares-deps

src/libs/antares/study/area/list.cpp

src/libs/antares/study/include/antares/study/area/capacityReservation.h

src/libs/antares/study/area/list.cpp

...le/include/antares/solver/variable/economy/reserveParticipationByDispatchableOffUnitsPlant.h

JasonMarechal25 · 2025-05-22T12:46:01Z

Hello. I've started to review this PR. I haven't read every thing yet.
My comment are often more on the "form" than the "matter".
One of the important point I would raise is the lack of unit testing.

Most of the comments are more on the "let's try to do it another way that I feel may be better" side rather than "I commend to do this". Feel free to challenge them or reach out directly for any question or discussion

src/libs/antares/study/parts/short-term-storage/container.cpp.orig

.github/workflows/windows-vcpkg.yml.orig

guilpier-code · 2025-05-26T15:10:12Z

.gitmodules

-	url = https://github.com/AntaresSimulatorTeam/Antares_Simulator_Tests_NR.git
-    branch = main
-    ignore = dirty
+	url = https://github.com/sylvmara/Antares_Simulator_Tests_NR.git


We should not forget to revert this file.

src/antares-deps

src/libs/antares/study/parts/common/cluster.cpp

src/libs/antares/utils/utils.cpp

guilpier-code · 2025-05-27T08:15:22Z

src/tests/resources/Antares_Simulator_Tests_NR

Same as above : please revert this change on sub module.

src/tests/cucumber/features/steps/common_steps/solver_steps.py.orig

src/tests/cucumber/features/steps/common_steps/solver_input_handler.py.orig

src/libs/antares/study/include/antares/study/parameters.h

src/libs/antares/study/area/list.cpp

src/libs/antares/study/include/antares/study/area/capacityReservation.h

src/libs/antares/study/include/antares/study/fwd.h

sonarqubecloud · 2025-08-20T14:42:33Z

Quality Gate failed

Failed conditions
43.8% Coverage on New Code (required ≥ 60%)
18.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

flomnes

Utiliser Type* plutôt que std::optional<std::reference_wrapper<Type>>

…ourly results

pull-request-size · 2025-09-29T13:16:37Z

This PR is too big. Please break it up into smaller PRs.

…g the symmetry

…culation

Review only, no merge

…e_model_lot3_scalian-sorties

…reserve_model_lot3_scalian

…e_model_lot3_scalian-sorties

- Fix issue on ReserveParticipation MARG.COST with the name - Fix issue with the ST group (duplicated groupName in the data structures) - Add columns to see EXP, std, min and max values for each output - Rework VCardReserveParticipationBase class with default values and add the possibility to output EXP, std, min, max or just EXP - Clean some functions related to the outputs

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merging after review

…reserve_model_lot3_scalian

pull-request-size bot added the size/XXL label Jan 13, 2025

JasonMarechal25 requested changes May 22, 2025

View reviewed changes

guilpier-code requested changes May 26, 2025

View reviewed changes

guilpier-code requested changes May 27, 2025

View reviewed changes

src/tests/resources/Antares_Simulator_Tests_NR

Copy link

Contributor

guilpier-code May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above : please revert this change on sub module.

guilpier-code reviewed May 27, 2025

View reviewed changes

sylvmara and others added 4 commits August 13, 2025 15:27

Corrected map errors

10fd62b

Merged with last version

1c15f0b

Formated using clang

ca3ebca

Merge branch 'develop' into feature/reserve_model_lot3_scalian

0f1a783

flomnes reviewed Sep 2, 2025

View reviewed changes

h-fournier and others added 13 commits September 3, 2025 11:15

Move reserve=enabled to the general section of generaldata.ini

0a66d26

Rename failureCost to unsuppliedCost

59ced10

Change optionnal reference wrapper to raw pointer

47ecabd

Corrected typo on reserve participation group

3247eed

Corecting bug on down reserves

187e277

Corrected imprecise tests

421a6ff

Corrected map bug on symmetries

805e4a7

Corrected bug on tests

079a74d

Marginal cost for reserves is now an int

4d3eef4

Modification of parameters for reserves

5e2a7ee

Corrected bad optionnal access for thermal

6088694

Corrected bugs inside reserve outputs

ed81344

Merged with develop and inversion of indexes for short term storage h…

06c825f

…ourly results

sylvmara and others added 2 commits September 29, 2025 15:33

Formated using clang

339d5c9

Update windows-vcpkg.yml

6b219ea

h-fournier and others added 30 commits January 6, 2026 13:55

Fix issue, need to check if reserveParticipations exists before addin…

5a14466

…g the symmetry

Fix compilation + throw exception for enum out of range

2922985

Split into functions to improve readability

526a48a

Fix output missing reserve participation per group and clean cost cal…

b1a66d5

…culation

Remove the fallback, it was not possible to enter it

11218a4

Keep fallback, but keep modifications on the hydro part

9626b5a

Group all reserve data to a single data structure

be4e0f4

Init reserveData struct with constructor

c1b4849

fix: bug multithread reserves (#3274)

2421909

[ANT-4171] Reserve - In memory input (#3259)

be3f540

Review only, no merge

Added a test for outputs to reserve participations by thermal clusters

6b88302

Merge branch 'feature/reserve_model_lot3_scalian' into feature/reserv…

861ddfa

…e_model_lot3_scalian-sorties

Merge branch 'feature/reserve_model_lot3_scalian' into feature/reserv…

3b657ed

…e_model_lot3_scalian-sorties

Merge branch 'feature/reserve_model_lot3_scalian' into feature/reserv…

04f5039

…e_model_lot3_scalian-sorties

Merge commit '609e642d75c2cbcdecbe13eb377129a1779ac605' into feature/…

2fa57b3

…reserve_model_lot3_scalian

Merge branch 'feature/reserve_model_lot3_scalian' into feature/reserv…

3e71daf

…e_model_lot3_scalian-sorties

Fix duplication

bb8f93e

Fix optionnal initialisation

b81bc62

Fix add GroupToResIndex

05e1de0

Try fix issue on CI

95a816d

Fix CI

b3bf3bb

[ANT-4172] Relecture réserves: sorties (#3287)

6a916d3

Change implementation to be supported by MSVC compiler

09da150

Comments fix and obsolete file deletion

ced14a8

Fix : Changed copy to reference

b8aad9e

Corrected comments on constraint 15 i

a8db3bf

Fix : comments

a58a445

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Relecture réserve: Optimisation / reserve sts (#3437)

09575e2

Merging after review

Merge commit 'e18ea60ce49e343e1ef91e05c2d442d313826be6' into feature/…

df31d47

…reserve_model_lot3_scalian

Conversation

h-fournier commented Jan 13, 2025 • edited by guilpier-code Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 4, 2025

Quality Gate failed

Uh oh!

sonarqubecloud bot commented May 19, 2025

Quality Gate failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JasonMarechal25 commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

guilpier-code May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guilpier-code May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 20, 2025

Quality Gate failed

Uh oh!

flomnes left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pull-request-size bot commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

h-fournier commented Jan 13, 2025 •

edited by guilpier-code

Loading

flomnes left a comment •

edited

Loading