refactor(config): use pydantic for config classes#2936
Draft
Conversation
Signed-off-by: Sylvain Leclerc <sylvain.leclerc@rte-france.com>
sylvlecl
commented
Jan 19, 2026
| model_config = ConfigDict( | ||
| frozen=True, | ||
| populate_by_name=True, | ||
| extra="ignore", |
Member
Author
There was a problem hiding this comment.
Don't think we should ignore
| filter_out: List[str] = field(default_factory=lambda: []) | ||
| groups: List[str] = field(default_factory=lambda: []) | ||
| # Handle jwt.key -> jwt_key | ||
| if "jwt" in data and isinstance(data["jwt"], dict): |
Member
Author
There was a problem hiding this comment.
might be possible to have a util function for this
| """Convert dict entries to WorkspaceConfig objects.""" | ||
| if isinstance(v, dict): | ||
| return { | ||
| key: WorkspaceConfig.model_validate(val) if isinstance(val, dict) else val for key, val in v.items() |
Member
Author
There was a problem hiding this comment.
typing issue to be fixed
TheoPascoli
force-pushed
the
dev
branch
2 times, most recently
from
b96b4f5 to
86503ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI generated so far, to be checked, cleaned up, improved