Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plum for type dispatch #1503

Closed
wants to merge 13 commits into from
Closed

Use plum for type dispatch #1503

wants to merge 13 commits into from

Conversation

RensDimmendaal
Copy link
Contributor

Part of moving dispatch and transform from fastcore to fasttransform (see here.

This PR removes the use of fastcore.dispatch.TypeDispatch and replaces it with plum.Function.

This needs to be done before merging the PR that removes dispatch and transform from fastcore. Because as long as nbdev depends on fastcore.dispatch removing the module will cause fastcore's integration tests to break.

Open questions:

  • version bump to which version?
  • changelog update?

@RensDimmendaal
Copy link
Contributor Author

will re-open w cleaned up git history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants