Update Config to support ConfigParser keyword arguments#659
Conversation
|
The integration test failure looks to be unrelated |
|
Yeah the integration test issue is due to a new bug in scipy, which has been fixed upstream but not released yet. |
jph00
left a comment
jph00
left a comment
There was a problem hiding this comment.
Thank you! Just a minor issue below.
There was a problem hiding this comment.
Could you install ipywidgets (IIRC) and re-run the cell with /Users/nathan/.venv/lib/python3.12/site-packages/tqdm/auto.py:21: TqdmWarning: IProgress not found. Please update jupyter and ipywidgets. See https://ipywidgets.readthedocs.io/en/stable/user_install.html so that warning doesn't turn up in the docs?
There was a problem hiding this comment.
Okay, this is fixed now, good catch!
There was a problem hiding this comment.
@jph00 anything else needed to get this merged in?
There was a problem hiding this comment.
Oops sorry got a bit behind over the xmas period! :O
2 participants
This PR adds a
cfg_kwargsargument to the Config object in the foundations module. This allows a user to pass keyword arguments directly to the ConfigParser object, allowing for things like overriding the behavior on how inline comments are handled. An example showcasing this functionality is also added to the docs.