Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to control logging level #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chicofranchico
Copy link

I used a less generic variable name marathon_logging_level so that it doesn't clash with other possible roles.

@chicofranchico
Copy link
Author

It seems that the zookeeper role is trying to pull a version that has been bumped already.

tasks/conf.yml Outdated
@@ -47,6 +47,11 @@
when: marathon_mesos_role != ""
notify: Restart marathon

- name: Set optional --logging_level option
template: src=logging_level.j2 dest=/etc/marathon/conf/logging_level
when: marathon_logging_level != "" or marathon_logging_level != "info"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marathon_logging_level != "info" this brings cofusion to one who will set variable to info level, maybe just leave first part?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I've updated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants