Skip to content

Conversation

@DustinsCode
Copy link

@DustinsCode DustinsCode commented Jul 26, 2022

Related issue: #224

Problem

Currently, when trying to complete the Master Chef achievement, one must first check the collections menu in order to see if a recipe they have the ingredients for has already been cooked and added to the collection. Sometimes they can make a mistake and spend precious ingredients on a recipe they have already made! Frustrating.

Solution

I have added a TextureBox that appears next to the cursor when hovering over a cooking recipe (only unlocked recipes, of course) that simply displays our beloved Queen of Sauce if the player has not yet cooked it. This takes out all of the back and forth checking between menus.

PSA

This was my first time ever trying something in the SV modding world as well as in the C# world.
Please let me know if there are any revisions you would like me to make! 😄

Screenshots

(Please excuse my other active mods)

Screenshot 2022-07-25 233426

Player has not yet cooked the Pink Cake, so Queen of Sauce is displayed.

Screenshot 2022-07-25 233447

Player has cooked the Fried Calamari, so Queen of Sauce is not displayed.

Started on feature to determine if craftable item is in collection.  Currently prints to SMAPI if cookable recipe is in player's collection.
Queen of Sauce displays in texturebox when hovering over cookable recipe player has not cooked yet
@Annosz Annosz added the enhancement New feature or request label Aug 13, 2022
Copy link

@MattPlays MattPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice implementation.

@DustinsCode
Copy link
Author

@Annosz This has been done, any chance of getting it merged in? :)

Copy link
Collaborator

@tqdv tqdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I can merge this without Annosz, but here's some feedback ^^

Also, I personally think that showHoverCraftableInCollection should be its own option in the config menu.

Edit: Forgot to say that otherwise, the code looks good! 👍

Comment on lines +35 to +38
public void Dispose()
{
throw new NotImplementedException();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the exception thrown on purpose or can it be safely removed ?

@Annosz
Copy link
Owner

Annosz commented Nov 6, 2022

Hi! Yes @tqdv, you can merge anything you find appropriate, I've seen a lot of high quality additions from you, so I trust your judgement :)

Sorry for the constant delay @DustinsCode on reviewing PRs, I hope now that @tqdv also has the right to accept them, the update cycle can be shorter.

I second the comment about 'showHoverCraftableInCollection' having a separate option in the config menu, it is a big enough feature. My only feedback is that would prefer consistency with existing functions, so if the icon had the same placing as the Full Shipment indicator, at the top left corner of the box:
image

@DustinsCode
Copy link
Author

Hi, it's been a while since I've looked at this. Very busy with work and all.

Last time I did look at this, I was trying to come up with a way to place the tool tip in the way mentioned above, but was struggling to get it placed in relation to the existing recipe tool tip, since that box's size can change depending on the content inside of it.

I'll have another go at it maybe this week or next as well as address the other suggestions

@TaciteOFF
Copy link

It would be great to be able to see if the player has already cooked that meal or not (for achievement purposes).
The "Informant" mod does it and it's the only feature missing in UI Info 2

@DustinsCode
Copy link
Author

DustinsCode commented May 6, 2024

It would be great to be able to see if the player has already cooked that meal or not (for achievement purposes). The "Informant" mod does it and it's the only feature missing in UI Info 2

@TaciteOFF Thanks for reminding me about this (and giving me some extra motivation to actually finish it)! I should have some time after work this week to pull this back up, get it updated, and hopefully get it in a ship-able state

@DustinsCode
Copy link
Author

This PR is super outdated and it's looking to be a pain to update. I'm going to close this so I can get my fork properly updated and then re-do some of this.

@DustinsCode
Copy link
Author

I opened a new PR for this feature with slightly expanded functionality for both cooking and crafting recipes! #528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants