Catch module uninstalled + code removed in same push (reroll of #120)

[bserem]

$(cat <<'EOF'

Summary

Reroll of #120 — the original PR added the safe-uninstall check directly into the monolithic sanity-check file, but sanity-check has since been refactored into a modular _lib/ architecture. This PR ports the same logic to fit that new structure.

• Adds critical_fail(), bail_if_critical(), and CRITICAL_ERRORS counter to commands/host/sanity-check
• Extracts the uninstall-safety check into a new commands/host/_lib/check-drupal-safe-uninstall.sh, sourced right after check-drupal-extensions.sh (which sets EXT_FILE)
• Updates scripts/git-hooks/pre-push to expose GIT_PUSH_RANGE_BASE/GIT_PUSH_RANGE_TIP from the push ref stdin, and blocks the push unconditionally (no bypass prompt) when a CRITICAL: line appears in sanity-check output

What it catches

When a developer tries to push a commit that simultaneously:

1. Removes a module from config/sync/core.extension.yml, and
2. Removes the drupal/<module> package from composer.lock (or the module directory is already gone from disk)

…the check flags it as CRITICAL and bail_if_critical exits with code 2. The pre-push hook detects the CRITICAL: string in the output and blocks the push with no option to continue — unlike normal sanity-check errors which can be bypassed with a y prompt.

The correct workflow is: uninstall the module → deploy → remove the code in a separate change.

Test plan

• Push a branch where core.extension.yml removes a module AND composer.lock removes drupal/<that_module> — push should be blocked with a CRITICAL message
• Push a branch where only the extension is removed (code still present) — should pass with a green tick
• Push a branch where only composer package is removed (extension still enabled) — unrelated to this check, should not be flagged here
• ddev sanity-check with no git changes — safe-uninstall section is silently skipped

https://claude.ai/code/session_01KWHPaEeFbQ9MKU2wLzaKNU
EOF
)

---

Generated by Claude Code

[bserem]

@dimitriskr can you do a functional review here please?

You'll have to simulate the problem:
Uninstall pathauto (or anything else)
and
Remove it from composer and try to push your changes

Thanks