fix(#1421): resolve replace-image-src against md/mdx frontmatter - #440
Merged
Conversation
Add a resolver that patches a content-collection frontmatter field
(e.g. `image: "/x.svg"`) when its value matches the drop target's
src. Layouts that render frontmatter through a dynamic expression
(`<img src={d.image} />`) have no literal <img src> for the .astro
resolver to find and no .mdoc body text for the .mdoc resolver to
match, so drag-drop image replacement always refused with
"no .mdoc files found" on stock (.md-content) sites.
Anglesite/Anglesite#1421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paired PR check
Anglesite/Anglesite-app.Test plan
npm test— 3158 passed, 1 pre-existing unrelated failure intest/optimize-images-packaging.test.jsdue to a missingtsxbinary in this fresh worktree, not touched by this change)test/fixtures/patcher/src/content/photos/*.mdfixtures anddescribe("frontmatter image resolver", …)intest/patcher.test.jscovering: quoted value match, unquoted plain-scalar match, no-match refusal, and ambiguous refusal (two files sharing the same image value)Closes Anglesite/Anglesite#1421