fix: prevent premature human_review status during validation

[bekalpaslan]

Summary

Fixes two critical bugs related to task phase/status display:

1. Validation Status Bug: Tasks marked as human_review (allowing merge) while validation phase was still running
2. Phase Display Bug: Dashboard task cards showing outdated phase (e.g., "planning") while task detail showed correct phase (e.g., "coding")

Problem 1: Premature Merge During Validation

As shown in the screenshot above, task 063-baseline-mapping-enhancements displays:

• Status: "Human Review" ✓ (purple badge)
• "Completed" ✓ (green badge)
• "10/10 subtasks" ✓
• BUT Validation phase is still "Running" ⚠️

This creates a dangerous situation where users can merge incomplete/unvalidated code.

Root Cause #1

The determineTaskStatusAndReason method in project-store.ts checked:

• ✅ Subtask completion
• ✅ QA report file status

But did NOT check:

• ❌ Validation phase status from task logs

When all subtasks completed, it immediately set status to human_review without waiting for validation to finish.

Solution #1

Added validation phase status checking:

// Check validation phase status from task logs (check both main and worktree logs)
const worktreeLogPath = path.join(specPath, '.worktrees', path.basename(specPath), 'task_log.json');
let validationPhaseActive = false;

// Check worktree logs first (validation runs in worktree)
if (existsSync(worktreeLogPath)) {
  const worktreeLog = JSON.parse(readFileSync(worktreeLogPath, 'utf-8'));
  validationPhaseActive = worktreeLog?.phases?.validation?.status === 'active';
}

// If validation is active, keep in ai_review (prevents merge)
if (validationPhaseActive) {
  calculatedStatus = 'ai_review';
}

Problem 2: Phase Display Inconsistency

Dashboard task tiles showed outdated phase (e.g., "planning") while task detail view showed the correct current phase (e.g., "coding").

Root Cause #2

The getTasks method populated Task objects but never set the executionProgress field. Dashboard task cards rely on task.executionProgress.phase to display the current phase badge, so they showed undefined or stale data.

Task detail view worked correctly because it separately loads task logs and finds the active phase.

Solution #2

Added execution progress determination to getTasks:

// Determine execution progress by checking active phase from task logs
let executionProgress: ExecutionProgress | undefined;
const taskLogPath = path.join(specPath, 'task_log.json');
const worktreeLogPath = path.join(specPath, '.worktrees', dir.name, 'task_log.json');

// Check worktree logs first (coding/validation runs in worktree)
let activePhase: 'planning' | 'coding' | 'validation' | null = null;
for (const logPath of [worktreeLogPath, taskLogPath]) {
  if (existsSync(logPath)) {
    const taskLog = JSON.parse(readFileSync(logPath, 'utf-8'));
    const phases = ['planning', 'coding', 'validation'] as const;
    for (const phase of phases) {
      if (taskLog?.phases?.[phase]?.status === 'active') {
        activePhase = phase;
        break;
      }
    }
    if (activePhase) break;
  }
}

// Map task log phase to execution phase
if (activePhase) {
  const phaseMap: Record<typeof activePhase, ExecutionPhase> = {
    'planning': 'planning',
    'coding': 'coding',
    'validation': 'qa_review'
  };
  executionProgress = {
    phase: phaseMap[activePhase],
    phaseProgress: 0,
    overallProgress: 0
  };
}

Changes

auto-claude-ui/src/main/project-store.ts:

Fix #1 - Validation Status:

• Lines 439-462: Added validation phase status check from task logs
• Lines 471-474: Keep task in ai_review while validation is active
• Added critical safety comment explaining the fix

Fix #2 - Phase Display:

• Lines 372-409: Determine executionProgress from task logs
• Line 443: Add executionProgress to Task object
• Line 5: Import ExecutionProgress and ExecutionPhase types

Testing

• ✅ TypeScript compilation passes without errors
• ✅ Fix Auto claude/add followup on done task #1 prevents status transition to human_review while validation is active
• ✅ Fix #2 ensures dashboard shows same phase as task detail view
• ✅ UI properly hides merge button when task is in ai_review
• ✅ Phase badges sync between dashboard and detail views

Impact

Before Fix #1: Users could merge code while validation was running ❌
After Fix #1: Merge button hidden until validation completes ✅

Before Fix #2: Dashboard showed stale phase (e.g., "planning") while detail showed current phase (e.g., "coding") ❌
After Fix #2: Dashboard and detail views show synchronized phase information ✅

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}