-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: comprehensive template system for scaffolding projects #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoshuaRileyDev
wants to merge
11
commits into
AndyMik90:develop
Choose a base branch
from
JoshuaRileyDev:template-system
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5c46bc9
feat: add default projects path setting with folder picker
JoshuaRileyDev 28fc3fa
feat: add project templates and secrets management system
JoshuaRileyDev 4c7ff2f
feat: enhance templates UI with full-width layout, search, and parame…
JoshuaRileyDev ab21ae9
fix: address security vulnerabilities in template system
JoshuaRileyDev 5eb12b6
Merge branch 'develop' into template-system
JoshuaRileyDev 31778b8
fix: comprehensive security improvements for template and secrets sys…
JoshuaRileyDev f8eb185
fix: resolve ESLint no-empty-pattern error in SecretsManager
JoshuaRileyDev 2737343
Merge branch 'develop' into template-system
JoshuaRileyDev 89f2a85
fix: resolve all TypeScript compilation errors
JoshuaRileyDev 1ebcc69
feat: add i18n support for template and secrets management components
JoshuaRileyDev 358f4a1
Merge branch 'develop' into template-system
AlexMadera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 2079
🏁 Script executed:
# Check the imports at the top of the file head -30 apps/frontend/src/main/ipc-handlers/project-handlers.tsRepository: AndyMik90/Auto-Claude
Length of output: 1048
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 13987
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 29374
🏁 Script executed:
Repository: AndyMik90/Auto-Claude
Length of output: 36930
Critical command injection vulnerability: user-provided
repoUrlis directly interpolated into shell command without sanitization.Line 513 executes
git clonewith user input via template literals. A maliciousrepoUrllikehttps://github.com/repo.git"; rm -rf / #would execute arbitrary commands.Replace
execSyncwithspawnSyncusing array syntax to prevent shell interpretation:import { execSync, spawnSync } from 'child_process';try { - execSync(`git clone "${repoUrl}" "${clonePath}"`, { - stdio: 'pipe', - encoding: 'utf-8' - }); + const result = spawnSync('git', ['clone', repoUrl, clonePath], { + stdio: 'pipe', + encoding: 'utf-8' + }); + if (result.error) { + throw result.error; + } } catch (gitError: any) {Also address:
catch (gitError: any)tocatch (gitError: unknown)for type safetyrepoUrlis a valid Git URL format🤖 Prompt for AI Agents