feat: Add daily automation workflow for Claude Kaizen tasks - #87
Conversation
Introduce a new GitHub Actions workflow that runs daily to automate code hygiene tasks. The workflow includes steps for checking out the repository, setting up Node.js and pnpm, and executing the Claude Code Kaizen action to identify and address code issues. This aims to enhance code quality through regular, incremental improvements.
📝 WalkthroughWalkthroughAdds a new GitHub Actions workflow Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Scheduler as GitHub Actions Scheduler (cron / workflow_dispatch)
participant Runner as Actions Runner
participant Repo as Repository
participant Claude as anthropics/claude-code-action
participant Validation as pnpm build/test/lint/typecheck
Scheduler->>Runner: trigger workflow
Runner->>Repo: checkout code
Runner->>Runner: setup Node 20 + pnpm, install deps (frozen lockfile)
Runner->>Claude: invoke claude-code-action (with claude_args)
Claude->>Repo: analyze repo, run allowed pnpm/git commands, create branch & commit changes (optional)
Runner->>Validation: run pnpm build/test/lint/typecheck
Validation-->>Runner: success/failure
alt validations pass and real issues fixed
Runner->>Repo: create PR with specified title/body/labels
else
Runner-->>Scheduler: exit (no PR created)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Code Review: Daily Automation Workflow for Claude KaizenThank you for adding this automation workflow! Here's my detailed feedback: Critical Issues1. Missing Dependency Installation (.github/workflows/claude-kaizen.yml:51)
2. Overly Permissive Tool Allowlist (.github/workflows/claude-kaizen.yml:52)
3. No Validation Step (.github/workflows/claude-kaizen.yml:39)
Major Concerns4. Workflow Quality Check (.github/workflows/claude-kaizen.yml:61-92)
5. Branch Naming Collision (.github/workflows/claude-kaizen.yml:76)
6. No Error Handling (.github/workflows/claude-kaizen.yml:39-95)
Minor Issues
Positive Aspects
RecommendationsHigh Priority: Add pnpm install step, tighten tool allowlist, add validation step Testing RecommendationBefore merging, test manually via workflow_dispatch and verify the generated PR passes all checks. Overall Assessment: Interesting concept, but needs security hardening and quality controls before production use. The risk of accidental publishes or forced changes is too high in the current form. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/claude-kaizen.yml:
- Line 76: The branch naming "kaizen/$(date +%Y-%m-%d)" can collide on same-day
runs; change the creation logic that builds this branch name to append a unique
suffix (for example use the short commit SHA via git rev-parse --short HEAD or a
timestamp/random suffix) or add a pre-check that detects an existing branch
named "kaizen/$(date +%Y-%m-%d)" and then reuse it or generate an
incremented/unique name; update the code that constructs the branch name string
(the place emitting "kaizen/$(date +%Y-%m-%d)") to implement one of these
strategies so concurrent or repeated runs won’t fail on branch creation.
🧹 Nitpick comments (2)
.github/workflows/claude-kaizen.yml (2)
43-48: Consider removing redundantadditional_permissions.The
additional_permissionsblock duplicates permissions already declared at the job level (lines 12-17). Unless the Claude Code action specifically requires this separate declaration, these may be unnecessary.
62-71: Potential tension between "no fabrication" rule and "exactly one item per category" requirement.Step 2 states Claude is "strictly forbidden from fabricating issues," but Step 3 requires "exactly one item for each category." If a category genuinely has no issues (e.g., no typos exist), this creates conflicting instructions. Consider allowing Claude to skip categories when no legitimate issues exist:
- Generate a task list containing exactly one item for each category below. + Generate a task list containing up to one item for each category below. Skip categories where no legitimate issue exists.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/claude-kaizen.yml
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: AndurilCode/mcp-apps-kit PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T17:08:06.621Z
Learning: Mandatory: Read `CLAUDE.md` before starting any task
Learnt from: CR
Repo: AndurilCode/mcp-apps-kit PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T17:08:06.621Z
Learning: All project instructions are in `CLAUDE.md`
📚 Learning: 2026-01-11T17:08:06.621Z
Learnt from: CR
Repo: AndurilCode/mcp-apps-kit PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T17:08:06.621Z
Learning: Mandatory: Read `CLAUDE.md` before starting any task
Applied to files:
.github/workflows/claude-kaizen.yml
📚 Learning: 2026-01-11T17:08:06.621Z
Learnt from: CR
Repo: AndurilCode/mcp-apps-kit PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-11T17:08:06.621Z
Learning: All project instructions are in `CLAUDE.md`
Applied to files:
.github/workflows/claude-kaizen.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test-and-lint
- GitHub Check: claude-review
🔇 Additional comments (3)
.github/workflows/claude-kaizen.yml (3)
1-7: LGTM!The workflow trigger configuration is well-structured with a daily schedule and manual dispatch option for testing.
9-17: LGTM!Permissions are appropriately scoped with clear comments explaining each permission's purpose.
19-35: No action needed. Theactions/checkout@v6andactions/setup-node@v6versions are both current and valid. As of January 2026, v6 is the latest major version for both actions.Likely an incorrect or invalid review comment.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 620978bd49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…validation steps Added concurrency settings to prevent multiple concurrent runs of the Claude Kaizen workflow. Updated the workflow to include a step for installing dependencies and refined the instructions for issue detection and PR generation, emphasizing the importance of real issues and validation checks before creating a PR.
Code Review: Claude Kaizen Daily Task WorkflowI've reviewed the proposed GitHub Actions workflow for automated code hygiene tasks. Overall, this is a well-structured workflow with thoughtful security constraints and a clear mission. However, there are several important issues to address. Critical Issues1. Validation Commands Don't Match CLAUDE.md RequirementsLocation: .github/workflows/claude-kaizen.yml:60 Issue: The allowed commands don't include pnpm format, but the existing PR check workflow (pr-check.yml:37) runs pnpm format as a separate step. The actual CI also checks formatting. Impact: The Kaizen bot could create PRs with formatting issues that will fail CI. Fix: Add Bash(pnpm format) to the allowed tools list. 2. Missing Format Command in Validation InstructionsLocation: .github/workflows/claude-kaizen.yml:85 Issue: The prompt instructs Claude to run pnpm build && pnpm test && pnpm lint && pnpm typecheck, but doesn't include pnpm format which is part of the actual CI pipeline. Fix: Update validation to: pnpm build && pnpm format && pnpm lint && pnpm typecheck && pnpm test 3. Wildcard Git Commands Are Too PermissiveLocation: .github/workflows/claude-kaizen.yml:60 Issue: Patterns like Bash(git add *) and Bash(git commit *) use shell-style wildcards. Recommendation: Use more specific patterns: Bash(git add .) or Bash(git commit -m *) High Priority Issues4. Missing pnpm -C Package-Specific CommandsIssue: CLAUDE.md documents pnpm -C packages/core test for faster iteration, but allowed tools don't permit this. Fix: Add: Bash(pnpm -C * test), Bash(pnpm -C * build) Medium Priority Issues5. Branch Name Collision RiskIssue: Branch naming YYYY-MM-DD-HHMM runs at exactly 6:00 AM UTC daily. Fix: Use GitHub run ID: kaizen/daily-20916715003 6. No Cleanup of Old Kaizen BranchesIssue: Daily branches accumulate without cleanup. Fix: Add workflow to delete merged kaizen branches older than 30 days. 7. Missing GitHub CLI CommandsIssue: Missing gh pr checks and gh pr status commands. Fix: Add for better CI observability. What's Done Well
Final VerdictWell-designed workflow with careful security consideration. However, the missing pnpm format command is a blocking issue that will cause CI failures. Recommendation: Request changes to add format validation, then approve. Must Fix Before Merge:
Should Fix: Nice to Have: |
…e allowed tools Added an environment variable for dynamic branch naming in the Claude Kaizen workflow to prevent collisions. Updated the allowed tools in the workflow to include package-specific commands for pnpm, improving the automation of code hygiene tasks.
Code Review: Daily Claude Kaizen WorkflowI've reviewed this PR that introduces an automated daily code hygiene workflow. Here's my feedback: ✅ Strengths
🔍 Issues & ConcernsCritical Issues
Medium Priority
Minor/Style Issues
🎯 RecommendationsMust Fix Before Merge:
Should Consider:
Nice to Have:
📝 Testing RecommendationsBefore merging, test via
🔒 Security Assessment✅ Good security practices:
Overall AssessmentThis is a well-designed automation workflow with thoughtful constraints and validation. The main issues are:
After addressing the critical issues, this should be safe to merge. The workflow demonstrates good understanding of the codebase requirements and automation best practices. Recommendation: Request changes to add format validation, then approve after fixes. |
… validation steps Enhanced the allowed tools in the Claude Kaizen workflow by adding pnpm format and install commands for improved dependency management and code formatting. Updated validation instructions to reflect these changes, ensuring all necessary checks are performed before PR creation.
Code Review: Claude Kaizen Daily Task WorkflowThank you for adding this automated code hygiene workflow! This is an interesting approach to maintaining code quality. I've reviewed the changes against the repository's CLAUDE.md conventions and best practices. Here's my feedback: ✅ Strengths
🐛 Potential Issues1. Inconsistent dependency installation (.github/workflows/claude-kaizen.yml:42)
2. Missing
|
19f0563 to
dd283b3
Compare
Code Review: Daily Claude Kaizen WorkflowSummaryThis PR introduces an automated daily workflow that uses Claude Code to perform incremental code hygiene improvements. The concept is interesting and aligns with the kaizen philosophy of continuous improvement. However, there are several important concerns that should be addressed before merging. 🟢 Strengths
🟡 Issues & Concerns1. CRITICAL: pnpm format behavior mismatch (.github/workflows/claude-kaizen.yml:72)The workflow runs pnpm format but the check is incorrect:
The prompt says run validation: pnpm format but pnpm format only checks, it does not fix formatting. The workflow should either use pnpm format:write before validation checks OR document that Claude needs to manually fix formatting issues. Without this, validation will fail on any formatting issues Claude creates. 2. Security: Overly broad bash command permissions (.github/workflows/claude-kaizen.yml:66)The claude_args allows wildcards that could be exploited: git add *, git commit *, pnpm install *. Consider more restrictive patterns like git add . and pnpm install --frozen-lockfile. 3. Missing coverage check (.github/workflows/claude-kaizen.yml:72)The pr-check.yml workflow runs pnpm test -- --coverage (line 46), but this workflow only runs pnpm test. Per CLAUDE.md:26, 50% test coverage - CI fails below this. The kaizen workflow should verify coverage. 4. Concurrency settings may cause issues (.github/workflows/claude-kaizen.yml:13)With cancel-in-progress: false, if a run is in progress when the next scheduled run triggers, the second run will queue. Given that Claude Code might take 10-30 minutes, runs could pile up. Consider cancel-in-progress: true or add timeout-minutes: 30. 5. Branch strategy unclear for push trigger (.github/workflows/claude-kaizen.yml:9)The workflow allows pushes to kaizen-job branch, but that branch does not exist in the repo. Is this for testing or should it be removed? 6. Validation sequence optimizationThe prompt recommends running all checks, but does not specify order. For faster feedback, run fast checks first: pnpm format:write && pnpm lint && pnpm typecheck && pnpm build && pnpm test -- --coverage 7. Missing error handling guidanceThe prompt does not clearly tell Claude what to do if pnpm install is needed, circular dependencies are detected by Nx, or test coverage drops below 50%. Should Claude attempt to fix these or just report them? 🔵 Performance Considerations
🟣 Best PracticesPositive:
Suggestions:
🧪 Test CoverageN/A - This is a workflow file with no test coverage requirements. However, you should test manually with workflow_dispatch before enabling scheduled runs and monitor the first few runs closely. 🔒 Security SummaryMedium Risk Items:
Mitigations:
📋 RecommendationsMust Fix (Blocking):
Should Fix (Important):
Nice to Have (Optional):
✅ Approval RecommendationREQUEST CHANGES - The workflow has good intentions and structure, but the pnpm format issue (item 1) will cause immediate validation failures. Fix the blocking issues and this will be good to merge. Great work on the comprehensive prompt and workflow structure! The kaizen approach could be valuable for maintaining code quality. Let me know if you would like help addressing any of these concerns. |
Code Review - Claude Kaizen Daily WorkflowSummaryThis PR introduces an automated daily workflow for code hygiene improvements using Claude Code. The workflow is well-structured and aligns with the repository's standards, but there are several concerns around security, correctness, and maintainability. 🔴 Critical Issues1. Format Command Misuse (.github/workflows/claude-kaizen.yml:70, 93)Issue: The prompt instructs Claude to run Impact: If code has formatting issues, Fix: Either:
Evidence:
2. Overly Permissive Bash Command Wildcards (.github/workflows/claude-kaizen.yml:64)Issue: The allowed tools include broad wildcards that could be exploited:
Security Risk: If Claude's behavior is manipulated (via prompt injection or bugs), these wildcards could lead to unintended operations. Fix: Be more specific with the allowed commands. 3. Missing Frozen Lockfile Flag (.github/workflows/claude-kaizen.yml:42)Issue: Line 42 uses Impact: Claude could modify pnpm-lock.yaml unintentionally, creating dependency drift. Fix: Remove the overly broad
|
1 participant
Introduce a new GitHub Actions workflow that runs daily to automate code hygiene tasks. The workflow includes steps for checking out the repository, setting up Node.js and pnpm, and executing the Claude Code Kaizen action to identify and address code issues. This aims to enhance code quality through regular, incremental improvements.