-
-
Notifications
You must be signed in to change notification settings - Fork 1
Auto-resize-mcp-apps #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
30f6593
feat(ui): Add autoResize option for MCP adapter and update related co…
gabe4coding 63b5e47
refactor(tools): Remove autoResize option from greeting widgets and e…
gabe4coding 049200c
refactor(mcp): Change McpAdapterOptions from interface to type defini…
gabe4coding 7c07b52
refactor(ui): Simplify destructuring and formatting in HTML and Vite …
gabe4coding 40e2b2d
feat(ui): Introduce autoResize option for MCP adapter and enhance rel…
gabe4coding dd2ab10
docs(ui): Update README formatting for `defineReactUI` options table
gabe4coding 49f514d
Fix autoResize default value in defineReactUI
gabe4coding 99ceda4
Fix critical issues in autoResize implementation
gabe4coding 21091fa
Improve autoResize documentation for cross-platform clarity
gabe4coding b435dfa
Add autoResize support to defineUI() for consistency
gabe4coding 62e3818
Update README.md formatting for `defineReactUI` options table
gabe4coding 22a4c81
Fix linting error in ui-react context
gabe4coding File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the
@defaultdocumentation forautoResize.The JSDoc states
@default true, but the test on line 154 ofpackages/core/tests/unit/ui-resources.test.tsshows that whenautoResizeis not specified, it remainsundefined, with the comment stating "The default is applied at the client-side adapter level."This creates ambiguity about whether:
trueat this type level, orundefinedwhen unspecified, and the client-side adapter applies a default oftrueConsider revising the JSDoc to clarify this behavior more accurately.
📝 Suggested JSDoc revision
Or alternatively, if the server-side definition truly doesn't have a default:
📝 Committable suggestion
🤖 Prompt for AI Agents