[pull] main from github:main#44
Merged
pull[bot] merged 4 commits intoAndroid-studio61:mainfrom May 7, 2026
Merged
Conversation
Remove validatePiEngineRequirements which is only reachable from CompileToYAML, itself unreachable from any production entry point. Also remove its exclusive test file pi_validation_test.go and the dead call site in compiler_string_api.go. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…rence specs (#30865) * Initial plan * docs: apply 2026-05-07 SPDD spec updates Agent-Logs-Url: https://github.com/github/gh-aw/sessions/30bfa3f9-8d10-479a-a943-4c09064f5423 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com> * docs: incorporate spec review feedback Agent-Logs-Url: https://github.com/github/gh-aw/sessions/30bfa3f9-8d10-479a-a943-4c09064f5423 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
…30871) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b8ce651c-48d1-47d2-afa9-87f74ef02496 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
* jsweep: clean add_reaction_and_edit_comment.cjs - Extract large switch statement into resolveEventEndpoints() helper - Move validReactions to module-level VALID_REACTIONS constant - Remove redundant if (commentUpdateEndpoint) guard after switch - Add explicit Record<string, string> type for EVENT_TYPE_DESCRIPTIONS - Export resolveEventEndpoints and VALID_REACTIONS for direct testing - Add 9 new tests for resolveEventEndpoints and VALID_REACTIONS (35 → 44) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * freeze VALID_REACTIONS array with Object.freeze() Agent-Logs-Url: https://github.com/github/gh-aw/sessions/fb12d090-f298-4a07-b4d3-b03e8e2d7d6a Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by cubic
Refactors the reaction/comment action for clearer endpoint resolution and stronger tests, and updates docs to favor fuzzy schedules while tightening several reference specs. Also removes dead Pi engine validation code in Go.
Refactors
resolveEventEndpoints()andVALID_REACTIONSinactions/setup/js/add_reaction_and_edit_comment.cjs; added 9 tests; simplified flow and consistent logging.validatePiEngineRequirementsand its tests; dropped call site inpkg/workflow/compiler_string_api.go.Docs
Written for commit 6eeb1f7. Summary will update on new commits.