Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native-comp warnings in *.el files #485

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

Hi-Angel
Copy link
Contributor

@Hi-Angel Hi-Angel commented Jan 27, 2024

There may be warnings in other files, I didn't look at those. I noticed two warnings in .yas-setup.el files, so decided to fix them; and I fixed warnings everywhere while at it 😊

The fact that everything compiles now without warnings was checked by a command:

emacs -batch --eval "(package-initialize) (setq byte-compile-error-on-warn t)" -f batch-byte-compile $(fnfx .el)

That revealed one doc-string warning, which I fixed in a separate commit.

Fixes a warning::
    snippets/prog-mode/.yas-setup.el:32:2: Warning: docstring wider than 80 characters
Fixes a bunch of warnings like:
    …/.yas-setup.el:1:1: Warning: file has no ‘lexical-binding’ directive on its first line
@Hi-Angel Hi-Angel changed the title Fix native-comp warnings in .yas-setup.el files Fix native-comp warnings in *.el files Jan 28, 2024
@Hi-Angel
Copy link
Contributor Author

Hi-Angel commented Feb 3, 2024

Ping

1 similar comment
@Hi-Angel
Copy link
Contributor Author

Ping

@AndreaCrotti AndreaCrotti merged commit 1080fc4 into AndreaCrotti:master Feb 21, 2024
2 checks passed
@AndreaCrotti
Copy link
Owner

Nice thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants