Add test coverage for AnchorDetail's FIX - #414
Merged
Jagadeeshftw merged 2 commits intoJul 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces comprehensive integration-level test coverage for the modal "Cancel" and "Keep" actions within both the
AnchorDetailandSettlementDetailcomponents. It guarantees that backing out of a destructive confirmation dialog (either deactivating an anchor or cancelling a pending settlement) does not trigger the underlying API endpoints (deregisterAnchor/cancelSettlement), and maintains the original state of the resource.Additionally, this PR fixes two critical pre-existing compilation and type errors in the production frontend code:
src/components/AnchorsPanel.tsx: Declared missinginitialSort,setSortParam, andsetDirParamreferences to complete the sorting mechanism and satisfy the TypeScript compiler.src/components/PoolsPanel.tsx: Declared the missingPoolsPanelPropsinterface and resolved custom hook type-signature conflicts withuseAsync.Both changes ensure that the production application builds and deploys correctly with zero errors, and all tests run with 100% success.
Closes #test-coverage-gap
Checklist
I added a
CHANGELOG.mdentry under the next## [0.9.2]section(see the Format note at the top of
CHANGELOG.md), or this PRis docs-only / test-only / internal tooling and doesn't change
user-facing behavior.
Tests added/updated for the change.
Closes #323