Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #116: Add --path-arrows option for arrow rendering #117

Merged
merged 10 commits into from
Feb 20, 2025

Conversation

napakalas
Copy link
Contributor

Issue #116

  • Updated the draw_arrow() function to do nothing by default. Introduced a new --path-arrows argument to enable arrow rendering on paths. Updated the README to reflect the usage of this new option.
  • Check circular path integrity by verifying centerline and nodes to ensure circularity. This resolves rendering issues with keast-4 and corrects rendering for unbranched-20 and unbranched-21. The following figure illustrates the keast-4 path before and after the update.

keast-4 before update
Screenshot 2025-02-17 at 12 26 50 PM

keast-4 after update
Screenshot 2025-02-17 at 12 29 02 PM

Copy link
Collaborator

@dbrnz dbrnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I had to "Review changes" and then "Submit review"...

@dbrnz dbrnz self-requested a review February 20, 2025 21:36
@dbrnz dbrnz merged commit 5fb0a93 into AnatomicMaps:main Feb 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants