Skip to content

Fixes for chapter 5 (Ledger Rules and Fraud Proofs) - #381

Open
mpetruska wants to merge 1 commit into
mainfrom
fix/fraud-proof-chapter-errata
Open

Fixes for chapter 5 (Ledger Rules and Fraud Proofs)#381
mpetruska wants to merge 1 commit into
mainfrom
fix/fraud-proof-chapter-errata

Conversation

@mpetruska

@mpetruska mpetruska commented Nov 20, 2025

Copy link
Copy Markdown
Contributor
  • fix uncovered typos
  • ready for review/merge

@mpetruska
mpetruska marked this pull request as ready for review November 26, 2025 09:28
@mpetruska
mpetruska requested a review from keyan-m November 26, 2025 09:29
@mpetruska mpetruska changed the title [WIP] Fixes for chapter 5 (Ledger Rules and Fraud Proofs) Fixes for chapter 5 (Ledger Rules and Fraud Proofs) Nov 26, 2025
@keyan-m

keyan-m commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

@mpetruska this is actually great timing. With withdrawal events now being optimistic and structured as below:

// ### Withdrawal event
pub type WithdrawalId =
OutputReference
pub type WithdrawalBody {
l2_outref: OutputReference,
l2_owner: VerificationKeyHash,
l2_value: ValuePairs,
l1_address: Address,
l1_datum: CardanoDatum,
}
pub type WithdrawalSignature =
Pair<VerificationKey, Signature>
pub type WithdrawalValidity {
WithdrawalIsValid
NonExistentWithdrawalUtxo
SpentWithdrawalUtxo { l2_tx_hash: H32<MidgardTxCompact> }
IncorrectWithdrawalOwner
IncorrectWithdrawalValue
IncorrectWithdrawalSignature
TooManyTokensInWithdrawal
}
pub type WithdrawalInfo {
body: WithdrawalBody,
signature: WithdrawalSignature,
validity: WithdrawalValidity,
}
pub type WithdrawalEvent {
id: WithdrawalId,
info: WithdrawalInfo,
}

Do you think this implementation is sufficient for adding corresponding fraud proofs in the specs? How sensible/practical would it be to pursue proving exhaustiveness of the possible invalidity claims?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants