feat(github): wire review cooldown into command handler#1834
Merged
atoomic merged 2 commits intoJun 9, 2026
Conversation
atoomic
reviewed
Jun 9, 2026
Collaborator
There was a problem hiding this comment.
we need to remove that file and ignore it from .github if not already the case
Collaborator
Author
There was a problem hiding this comment.
Add .branch-cleanup-tracker.json to .gitignore. File tracks local cleanup timestamps, should not be versioned. Check if .github/ references it and remove if present.
atoomic
approved these changes
Jun 9, 2026
Collaborator
Author
PR Review — feat(github): wire review cooldown into command handlerSolid implementation of review cooldown wiring. One consistency issue to fix.
Checklist
Automated review by Kōan (Ollama-launch · model qwen3.5:cloud) |
Wire github_notification_tracker review cooldown into the command handler: - In _try_assignment_notification (review_requested path): - Check is_review_on_cooldown before queuing a review mission - Call set_review_cooldown after successfully queuing - In process_single_notification (@mention /review path): - Call set_review_cooldown after successfully queuing a review mission - Remove TODO from set_review_cooldown since it's now wired - Add tests covering cooldown skip, cooldown set, and non-review assignments not touching the cooldown tracker Belt-and-suspenders guard: the head-SHA thread tracker is the primary re-review dedup; the cooldown catches cases where a new notification slips through with the same head SHA within the 30-minute window.
Collaborator
Author
Rebase with requested adjustmentsBranch Changes applied
StatsActions performed
CI statusCI will be checked asynchronously. Automated by Kōan |
BabyKoan
force-pushed
the
koan.atoomic/review-cooldown-wiring
branch
from
9775478 to
43e5e04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Wire the review cooldown tracker into the GitHub command handler so queued reviews record a 30-minute cooldown window.
Why: Prevents the review_requested → review → rebase → new SHA → re-review feedback loop by adding a belt-and-suspenders guard alongside the head-SHA thread tracker.
How:
Testing:
Quality Report
Changes: 4 files changed, 157 insertions(+), 10 deletions(-)
Code scan: clean
Tests: passed (403
tests)
Branch hygiene: clean
Generated by Kōan