Gvi to points

[ioalexei]

Addresses issue #8

Adds file assign_gvi_to_points.py

Input:

1. mapillary images directory
2. interim points file generated by create_points.py
3. an output directory (I've been using data/processed as default)

Output:
The module will output a GeoPackage file called image_points_with_gvi.gpkg in the output directory.

Example usage:

python3 -m src.assign_gvi_to_points /data/raw/mapillary /data/interim/sample_images.gpkg /data/processed

Still to do - flesh out the info/examples for --help

[danbjoseph]

I was able to run things successfully! Thanks for working on this 😄

• Please also update pyproject.toml with the new dependencies.
• In previous steps, instead of just the output directory, it also takes the filename and I think it will write in different geospatial file format according to the extension. Since the process might be run more than once or on multiple datasets, it would be good to be able to set the filename in the command.
• Did you run the linting and formatting checks?

Something seems off (either with the methodology or with the code) based on a spot check of the 3 highest and 3 lowest GVI scores.

High

81.8

81

80.8

Low

2

1.2

1.14

[ioalexei]

Updated:

• New dependencies added to pyproject.toml
• Formatting applied
• Changed output directory to output file - user can enter a file path and user-defined filename/format for the output

[ioalexei]

Spot checks definitely look odd. I didn't touch the GV score function but will take a look and compare to the sample from Treepedia to see if I can spot anything off.

[dragonejt]

Please address the os built-in library being in pyproject.toml, the rest of my comments are nits that you can choose to implement or not. Thanks so much for your work!

[ioalexei]

Thanks @dragonejt - should all be addressed now.