Skip to content

Update handling of Zlib by configure#1130

Merged
drroe merged 8 commits intoAmber-MD:masterfrom
drroe:update.libs
Feb 15, 2025
Merged

Update handling of Zlib by configure#1130
drroe merged 8 commits intoAmber-MD:masterfrom
drroe:update.libs

Conversation

@drroe
Copy link
Contributor

@drroe drroe commented Feb 14, 2025

Updates the downloaded zlib version to something more current. Make sure if zlib is built/specified it is passed to HDF5 (if also being built). Remove dependence on bc.

@drroe drroe self-assigned this Feb 14, 2025
@drroe
Copy link
Contributor Author

drroe commented Feb 14, 2025

I really do dislike python...

==================================== ERRORS ====================================
__________________ ERROR collecting tests/run_simple_test.py ___________________
ImportError while importing test module '/home/runner/work/cpptraj/cpptraj/pytraj/tests/run_simple_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/share/miniconda/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
run_simple_test.py:6: in <module>
    from pytraj import *
/usr/share/miniconda/lib/python3.10/site-packages/pytraj-2.0.6.dev0-py3.10-linux-x86_64.egg/pytraj/__init__.py:24: in <module>
    from .utils.misc import info
/usr/share/miniconda/lib/python3.10/site-packages/pytraj-2.0.6.dev0-py3.10-linux-x86_64.egg/pytraj/utils/misc.py:7: in <module>
    from pytraj.core.c_options import set_world_silent
/usr/share/miniconda/lib/python3.10/site-packages/pytraj-2.0.6.dev0-py3.10-linux-x86_64.egg/pytraj/core/__init__.py:2: in <module>
    from .topology_objects import Atom, Residue, Molecule
E   ImportError: /usr/share/miniconda/lib/python3.10/site-packages/numpy/_core/../../../../libstdc++.so.6: version `GLIBCXX_3.4.32' not found (required by /home/runner/work/cpptraj/cpptraj/lib/libcpptraj.so)

Going to see if pinning pytraj testing to python 3.12 magically fixes conda.

@drroe
Copy link
Contributor Author

drroe commented Feb 14, 2025

Well at least it's running now. Have an actual test failure: https://github.com/Amber-MD/cpptraj/actions/runs/13337802400/job/37256651726?pr=1130

@hainm , in your opinion could this be a numpy version thing?

@hainm
Copy link
Contributor

hainm commented Feb 14, 2025

@hainm , in your opinion could this be a numpy version thing?

I am not so sure. May be try to keep the 2.0.0 for now?

@drroe drroe merged commit 2434906 into Amber-MD:master Feb 15, 2025
11 checks passed
@drroe drroe deleted the update.libs branch February 15, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants