Update handling of Zlib by configure#1130
Merged
drroe merged 8 commits intoAmber-MD:masterfrom Feb 15, 2025
Merged
Conversation
Contributor
Author
|
I really do dislike python... Going to see if pinning pytraj testing to python 3.12 magically fixes conda. |
Contributor
Author
|
Well at least it's running now. Have an actual test failure: https://github.com/Amber-MD/cpptraj/actions/runs/13337802400/job/37256651726?pr=1130 @hainm , in your opinion could this be a numpy version thing? |
Contributor
I am not so sure. May be try to keep the 2.0.0 for now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the downloaded zlib version to something more current. Make sure if zlib is built/specified it is passed to HDF5 (if also being built). Remove dependence on
bc.