Try harder when forcing coroutines to unwind #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`force_unwind` currently panics if, after starting the unwind, the coroutine suspends itself or returns normally. Instead of this, we now rethrow the exception on suspend until the coroutine has finished, and then discard any returned value.
Amanieu
force-pushed
the
unwind-harder
branch
from
94befca to
04d7b68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
force_unwindcurrently panics if, after starting the unwind, the coroutine suspends itself or returns normally. Instead of this, we now rethrow the exception on suspend until the coroutine has finished, and then discard any returned value.Fixes #57