Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for running apps and localtest with test containers for integration testing #136

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Feb 9, 2025

I would consider this a cleanup PR with a few changes to localtest that would simplify using localtest for integration testing in testcontainers.

@ivarne ivarne requested a review from martinothamar February 9, 2025 21:18
@martinothamar
Copy link
Contributor

Generally LGTM. Can we use YARP for the proxying instead? I've tried something like this before as well and dicovered quickly there is more nuance. YARP was pretty well-abstracted last I tried, it was possible to use as a simple library: https://github.com/dotnet/yarp/blob/41e563cced47925142bd5c6ddeb1e2958e0ebabd/src/ReverseProxy/Forwarder/HttpForwarder.cs#L27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants