Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for ActionController using IInstanceDataMutator #900

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Add tests for ActionController using IInstanceDataMutator #900

merged 1 commit into from
Nov 11, 2024

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 8, 2024

I caught two minor errors

  • Don't return deleted elements in UpdatedDataModels for UserActions
  • Use the Mutator instead of Accessor in UserActionContext

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivarne ivarne merged commit 63cfd90 into main Nov 11, 2024
12 checks passed
@ivarne ivarne deleted the chore/add-data-mutator-tests-for-userAction branch November 11, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinothamar martinothamar martinothamar approved these changes

Assignees
No one assigned
Labels
ignore-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivarne @martinothamar