-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated text for deletion page and component #14708
base: main
Are you sure you want to change the base?
chore: updated text for deletion page and component #14708
Conversation
📝 WalkthroughWalkthroughThe changes update deletion confirmation text strings in the language file. Both the component and page deletion messages have been simplified by replacing references to "Summary-komponenter" with "avhengigheter" and streamlining the wording. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14708 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 1914 1914
Lines 24947 24947
Branches 2856 2856
=======================================
Hits 23890 23890
Misses 798 798
Partials 259 259 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep this as two separate text keys—one for pages and one for components—while adjusting the text based on @Annikenkbrathen's suggestion. That seems better than komponenten/siden
.
Edit, if we want to keep one text key, maybe "Er du sikker på at du vil slette? Alle avhengigheter til denne vil også bli slettet."
@Ildest, do you have a suggestion?
Not sure if I have understood this correctly, but I think it is important that we say what we are deleting, so maybe keep the text and say "Er du sikker på at du vil slette siden? Alle avhengigheter tilden blir også slettet." Og det samme for komponent. If the suggestion is to merge the massages and have "siden/komponenten" it is OK, but no ideal. A separate message for each is clearer to the user, and we already have that for group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :-).
Description
Updated the text for nativ popover when we delete page or component in
utforming
.Related Issue(s)
Verification
Documentation
Summary by CodeRabbit