Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the javascript to allow web stats gathering. #375

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

bennyvasquez
Copy link
Member

Added the javascript for matomo using the code from the dashboard and the directions in this issue. When deploying locally, it seems to do so without any errors, and it looks like it's including the code in the source, so I think it should be okay!

2024-03-27_16-07-10

@bennyvasquez bennyvasquez added the enhancement New feature or request label Mar 27, 2024
@codyro
Copy link
Member

codyro commented Mar 27, 2024

@jonathanspw You were attempting to do this the other day. I'm not sure what issues you were experiencing, but this appears fine to me.

Mind chiming in?

@jonathanspw
Copy link
Member

I just couldn't find a way to do it. If this works I'm 100% good with it, though, the footer would be more ideal if that's possible.

@bennyvasquez
Copy link
Member Author

I've honestly never heard of including this kind of code in the footer. Is there a specific reason? Just making it the last thing to load, or something?

@jonathanspw
Copy link
Member

Yep, just so DOM doesn't waste time on it until everything else is done. It's a common practice for all tracking code and unnecessary stuff to go into the footer for this reason.

https://www.corewebvitals.io/pagespeed/head-vs-footer-javascript-and-core-web-vitals

@bennyvasquez
Copy link
Member Author

Sweet! It doesn't look like that's possible yet with Vuepress, so I opened an issue here: vuejs/vuepress#3209

@jonathanspw
Copy link
Member

lgtm then

@bennyvasquez bennyvasquez merged commit 967c7b3 into master Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants